Skip to content

Avoid all service-related codegen when AddServicesExtension=false #295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kzu merged 1 commit into from
Dec 17, 2025
Merged

Avoid all service-related codegen when AddServicesExtension=false #295

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions DependencyInjection.slnx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,5 @@
<Project Path="src/CodeAnalysis.Tests/CodeAnalysis.Tests.csproj" />
<Project Path="src/DependencyInjection.Tests/DependencyInjection.Tests.csproj" />
<Project Path="src/DependencyInjection/DependencyInjection.csproj" />
<Project Path="src/NoAddServices/NoAddServices.csproj" />
</Solution>
6 changes: 1 addition & 5 deletions src/CodeAnalysis.Tests/AddServicesAnalyzerTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,7 @@
using System;
using System.Collections.Generic;
using System.Collections.Immutable;
using System.Collections.Immutable;
using System.IO;
using System.Linq;
using System.Threading.Tasks;
using Devlooped.Extensions.DependencyInjection;
using Microsoft.CodeAnalysis.CSharp;
using Microsoft.CodeAnalysis.CSharp.Testing;
using Microsoft.CodeAnalysis.Testing;
using Xunit;
Expand Down
3 changes: 3 additions & 0 deletions src/DependencyInjection/IncrementalGenerator.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -339,6 +339,9 @@ void ReportInconsistencies(SourceProductionContext context, ImmutableArray<Servi

void AddPartial(string methodName, SourceProductionContext ctx, (ImmutableArray<KeyedService> Types, Compilation Compilation) data)
{
if (data.Types.IsEmpty)
return;

var builder = new StringBuilder()
.AppendLine("// <auto-generated />");

Expand Down
22 changes: 22 additions & 0 deletions src/NoAddServices/NoAddServices.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
<Project Sdk="Microsoft.NET.Sdk">

<Import Project="..\DependencyInjection\Devlooped.Extensions.DependencyInjection.props" />

<PropertyGroup>
<TargetFramework>net10.0</TargetFramework>
<EmitCompilerGeneratedFiles>true</EmitCompilerGeneratedFiles>
<!-- This property causes no AddXXX partial methods to be emitted -->
<AddServicesExtension>false</AddServicesExtension>
</PropertyGroup>

<ItemGroup>
<PackageReference Include="Microsoft.Extensions.DependencyInjection.Abstractions" Version="10.0.1" />
</ItemGroup>

<ItemGroup>
<ProjectReference Include="..\DependencyInjection\DependencyInjection.csproj" ReferenceOutputAssembly="false" OutputItemType="Analyzer" />
</ItemGroup>

<Import Project="..\DependencyInjection\Devlooped.Extensions.DependencyInjection.targets" />

</Project>