Improve integration with MEAI typical usage pattern #53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
🧪 Details on Ubuntu 24.04.2 LTSfrom dotnet-retest v0.7.1 on .NET 8.0.17 with 💜 by @devlooped |
In MEAI, the expectation is that you get chat clients for specific models from the same OpenAI client. There's no concept of a default model at that level. This aligns the implementation with that approach. In addition, we add an analyzer that ensures the user can still invoke `GetChatClient(model).AsIChatClient()` while getting the proper behavior which in our `GrokClient` case is that you should use the returned client from `GetChatClient(model)` directly without an additional wrapping done by the MEAI `AsIChatClient`, since we implement the `IChatClient` in the returned client directly. This allows us to cache and use multiple chat clients dynamically matching the model in each request's ChatOptions. This also fixes a bug where we were not properly setting the search mode to On instead of Auto when using Tools.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In MEAI, the expectation is that you get chat clients for specific models from the same OpenAI client. There's no concept of a default model at that level.
This aligns the implementation with that approach.
In addition, we add an analyzer that ensures the user can still invoke
GetChatClient(model).AsIChatClient()while getting the proper behavior which in ourGrokClientcase is that you should use the returned client fromGetChatClient(model)directly without an additional wrapping done by the MEAIAsIChatClient, since we implement theIChatClientin the returned client directly.This allows us to cache and use multiple chat clients dynamically matching the model in each request's ChatOptions.
This also fixes a bug where we were not properly setting the search mode to On instead of Auto when using Tools.