-
Notifications
You must be signed in to change notification settings - Fork 7
Implement third party E2, E5, E6 violations #32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
dendmicap
wants to merge
6
commits into
devonfw-sample:violations/thirdparty
Choose a base branch
from
dendmicap:add-third-party-violations
base: violations/thirdparty
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
14eb076
third party E2, E5, E6 violations
dendmicap 9086d1d
Merge branch 'devonfw-sample:master' into add-third-party-violations
dendmicap 1a52b45
Merge branch 'devonfw-sample:master' into add-third-party-violations
dendmicap 3df609b
moved violations and fixed mysema violation
dendmicap a68555c
Merge branch 'violations/thirdparty' into add-third-party-violations
hohwille 251ed7e
Update ThirdPartyDataMappingPersistanceOk.java
hohwille File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 changes: 8 additions & 0 deletions
8
.../sample/archunit/general/dataaccess/violations/ThirdPartyDataMappingPersistanceNotOk.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| package com.devonfw.sample.archunit.general.dataaccess.violations; | ||
|
|
||
| import javax.persistence.Convert; // Noncompliant | ||
|
|
||
| @Convert | ||
| public class ThirdPartyDataMappingPersistanceNotOk { | ||
|
|
||
| } |
8 changes: 8 additions & 0 deletions
8
...nfw/sample/archunit/general/dataaccess/violations/ThirdPartyDataMappingPersistanceOk.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| package com.devonfw.sample.archunit.general.dataaccess.violations; | ||
|
|
||
| import javax.persistence.Converter; // compliant | ||
|
|
||
| @Converter | ||
| public class ThirdPartyDataMappingPersistanceOk { | ||
|
|
||
| } | ||
9 changes: 9 additions & 0 deletions
9
...java/com/devonfw/sample/archunit/general/dataaccess/violations/ThirdPartyMysemaNotOk.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| package com.devonfw.sample.archunit.general.dataaccess.violations; | ||
|
|
||
| import com.mysema.query.jpa.impl.JPAQuery; // Noncompliant | ||
|
|
||
| public class ThirdPartyMysemaNotOk { | ||
|
|
||
| JPAQuery jpaQuery; | ||
|
|
||
| } |
9 changes: 9 additions & 0 deletions
9
...in/java/com/devonfw/sample/archunit/general/dataaccess/violations/ThirdPartyMysemaOk.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| package com.devonfw.sample.archunit.general.dataaccess.violations; | ||
|
|
||
| import com.querydsl.jpa.impl.JPAQuery; // compliant | ||
|
|
||
| public class ThirdPartyMysemaOk { | ||
|
|
||
| JPAQuery<Integer> jpaQuery; | ||
|
|
||
| } |
9 changes: 9 additions & 0 deletions
9
...java/com/devonfw/sample/archunit/general/dataaccess/violations/ThirdPartyObjectNotOk.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| package com.devonfw.sample.archunit.general.dataaccess.violations; | ||
|
|
||
| import static com.google.common.base.Objects.equal; // Noncompliant | ||
|
|
||
| public class ThirdPartyObjectNotOk { | ||
|
|
||
| boolean result = equal(1, 1); | ||
|
|
||
| } |
8 changes: 8 additions & 0 deletions
8
...in/java/com/devonfw/sample/archunit/general/dataaccess/violations/ThirdPartyObjectOK.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| package com.devonfw.sample.archunit.general.dataaccess.violations; | ||
|
|
||
| // compliant: standard java object method equals() | ||
| public class ThirdPartyObjectOK { | ||
|
|
||
| boolean result1 = java.util.Objects.equals(1, 1); | ||
|
|
||
| } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.