#809: Enhance uninstall with --force to remove from the software repo

[juliane-cap]

Fixes: #809

Implements:

• function to fully delete a tool from the _ide software repository via --force
• unit test for the forced uninstall

[CLAassistant]

All committers have signed the CLA.

[coveralls]

Pull Request Test Coverage Report for Build 15062852418

Details

• 0 of 0 changed or added relevant lines in 0 files are covered.
• 26 unchanged lines in 1 file lost coverage.
• Overall coverage increased (+0.01%) to 67.719%

---

Files with Coverage Reduction	New Missed Lines	%
com/devonfw/tools/ide/tool/LocalToolCommandlet.java	26	83.12%

Totals
Change from base Build 15050843818:	0.01%
Covered Lines:	8016
Relevant Lines:	11430

---

💛 - Coveralls

[jan-vcapgemini]

@juliane-cap thanks for the enhancement of the uninstall commandlet with the force mode.
Everything looks fine to me. It would be nice if you could also add some simple tests which ensure that the software was actually deleted from the repository.
I've also added some small change requests, please check these.

[juliane-cap]

@jan-vcapgemini would LocalToolCommandlet.forceUninstall() work on macOs or should i use the macOsHelper to get the real path?
Path repoPath = getInstalledSoftwareRepoPath();
Path realPath = getMacOsHelper().findLinkDir(repoPath, getBinaryName());

[jan-vcapgemini]

Thanks for adding a new test and implementing the CRs. I've added some more very small CRs, after these are solved, the PR is ready for review.

[jan-vcapgemini]

@jan-vcapgemini would LocalToolCommandlet.forceUninstall() work on macOs or should i use the macOsHelper to get the real path? Path repoPath = getInstalledSoftwareRepoPath(); Path realPath = getMacOsHelper().findLinkDir(repoPath, getBinaryName());

Your current implementation with the added check for MacOs should work fine I think.

[hohwille]

@juliane-cap thanks for your PR and rework. Great job and nice improvements (including help texts, etc.). 👍
I still left some review comments for improvement. When resolved we can finally merge.

[hohwille]

@juliane-cap thanks for addressing all review comments. Perfect now and ready for merge Good job👍

[jan-vcapgemini]

I've tested these changes on Linux, Mac and Windows and it worked on all systems.