#1264: Fix ide.bat to detect errors properly#1274
Merged
hohwille merged 15 commits intodevonfw:mainfrom May 15, 2025
Merged
Conversation
Collaborator
Pull Request Test Coverage Report for Build 14997240991Details
💛 - Coveralls |
hohwille
reviewed
Apr 28, 2025
alfeilex
commented
May 6, 2025
…m/alfeilex/IDEasy into devonfw#1264-fix-bat-err-handling
alfeilex
changed the title
…m/alfeilex/IDEasy into devonfw#1264-fix-bat-err-handling
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #1264
This PR fixes the
ide.batto detect errors properly. The%ERRORLEVEL%is moved to outside the brackets to be set with the correct exit code that is given by the previousideasycommand. Ifideasyis run without arguments, then the error handling is skipped to prevent that previous%ERRORLEVEL%values that have been set by other commands, are not used in the error handing.I tested the behavior by comparing the output of various
idecommands ingit-bashandcmdside by side and they behave equal.You can test the behavior by replacing the code of
ide.batinprojects/_ide/installation/bin/ide.bat