#716 Add VSCode extension installation visualization#1308
Merged
jan-vcapgemini merged 11 commits intodevonfw:mainfrom May 27, 2025
Merged
#716 Add VSCode extension installation visualization#1308jan-vcapgemini merged 11 commits intodevonfw:mainfrom
jan-vcapgemini merged 11 commits intodevonfw:mainfrom
Conversation
Implemented: progress bar when installing vs code extensions, output is not finished yet
juliane-cap
added
vscode
Collaborator
Pull Request Test Coverage Report for Build 15269062822Details
💛 - Coveralls |
Member
|
@juliane-cap I implemented story #1314 in PR #1318. We can review and merge this to |
jan-vcapgemini
requested changes
May 26, 2025
Contributor
jan-vcapgemini
left a comment
jan-vcapgemini
left a comment
There was a problem hiding this comment.
@juliane-cap thanks for your PR. I've tested it with a local native image and it worked as expected. I've added some CRs please check.
cli/src/main/java/com/devonfw/tools/ide/process/ProcessContext.java
Outdated
Show resolved
Hide resolved
jan-vcapgemini
approved these changes
May 27, 2025
Contributor
jan-vcapgemini
left a comment
jan-vcapgemini
left a comment
There was a problem hiding this comment.
LGTM. Ready for merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes: #716
Implemented changes:
Checklist for this PR
Make sure everything is checked before merging this PR. For further info please also see
our DoD.
mvn clean testlocally all tests pass and build is successful#«issue-id»: «brief summary»(e.g.#921: fixed setup.bat). If no issue ID exists, title only.In Progressand assigned to you or there is no issue (might happen for very small PRs)with
internal