Skip to content

#351: prevent environment variables from other project causing side-effects#1327

Merged
jan-vcapgemini merged 7 commits intodevonfw:mainfrom
hohwille:feature/351-prevent-variables-from-other-project
May 23, 2025
Merged

#351: prevent environment variables from other project causing side-effects#1327
jan-vcapgemini merged 7 commits intodevonfw:mainfrom
hohwille:feature/351-prevent-variables-from-other-project

Conversation

@hohwille
Copy link
Member

@hohwille hohwille commented May 20, 2025

This PR fixes #351.

Implemented changes:


Checklist for this PR

Make sure everything is checked before merging this PR. For further info please also see
our DoD.

  • When running mvn clean test locally all tests pass and build is successful
  • PR title is of the form #«issue-id»: «brief summary» (e.g. #921: fixed setup.bat). If no issue ID exists, title only.
  • PR top-level comment summarizes what has been done and contains link to addressed issue(s)
  • PR and issue(s) have suitable labels
  • Issue is set to In Progress and assigned to you or there is no issue (might happen for very small PRs)
  • You followed all coding conventions
  • You have added the issue implemented by your PR in CHANGELOG.adoc unless issue is labeled
    with internal

@github-project-automation github-project-automation bot moved this to 🆕 New in IDEasy board May 20, 2025
@hohwille hohwille added enhancement New feature or request environment EnvironmentCommandlet, env variables, path, etc. labels May 20, 2025
@hohwille hohwille moved this from 🆕 New to Team Review in IDEasy board May 20, 2025
@hohwille hohwille added this to the release:2025.05.002 milestone May 20, 2025
@hohwille hohwille self-assigned this May 20, 2025
@coveralls
Copy link
Collaborator

coveralls commented May 20, 2025

Pull Request Test Coverage Report for Build 15217001708

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.08%) to 67.878%

Totals Coverage Status
Change from base Build 15216934814: 0.08%
Covered Lines: 8073
Relevant Lines: 11491

💛 - Coveralls

@jan-vcapgemini jan-vcapgemini self-requested a review May 21, 2025 09:37
Copy link
Contributor

@jan-vcapgemini jan-vcapgemini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Tested with a local graalvm native image.
Before:
image
After:
image

@jan-vcapgemini jan-vcapgemini merged commit 17c699c into devonfw:main May 23, 2025
4 checks passed
@github-project-automation github-project-automation bot moved this from Team Review to ✅ Done in IDEasy board May 23, 2025
@jan-vcapgemini
Copy link
Contributor

I've tested these changes on Windows, Linux and Mac and it worked on all systems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request environment EnvironmentCommandlet, env variables, path, etc.

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

Avoid inheriting environment variables from other IDEasy project if switched in the same shell session

3 participants