Skip to content

#1307: Fixed link to correct documentation page.#1335

Merged
jan-vcapgemini merged 7 commits intodevonfw:mainfrom
raveendra11:feature
May 23, 2025
Merged

#1307: Fixed link to correct documentation page.#1335
jan-vcapgemini merged 7 commits intodevonfw:mainfrom
raveendra11:feature

Conversation

@raveendra11
Copy link
Contributor

@raveendra11 raveendra11 commented May 22, 2025

This PR fixes #1307.

Implemented changes:

  • Fixed link to correct documentation page.

Checklist for this PR

Make sure everything is checked before merging this PR. For further info please also see
our DoD.

  • When running mvn clean test locally all tests pass and build is successful
  • PR title is of the form #«issue-id»: «brief summary» (e.g. #921: fixed setup.bat). If no issue ID exists, title only.
  • PR top-level comment summarizes what has been done and contains link to addressed issue(s)
  • PR and issue(s) have suitable labels
  • Issue is set to In Progress and assigned to you or there is no issue (might happen for very small PRs)
  • You followed all coding conventions
  • You have added the issue implemented by your PR in CHANGELOG.adoc unless issue is labeled
    with internal

@CLAassistant
Copy link

CLAassistant commented May 22, 2025

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@jan-vcapgemini jan-vcapgemini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@raveendra11 thank you for your PR. I've added a small CR. Please use our PR template (some to-dos f.e. adjusted CHANGELOG.adoc) were not applied. Also, please accept the CLA otherwise we can't merge this PR.
PS: I think you need to adjust your author information of your commit (needs to reflect your github username and e-mail) and do a force push to repair this PR.
git commit --amend --author="Author Name <email@address.com>" --no-edit

raveendra11 and others added 2 commits May 23, 2025 06:05
…ateCommandlet.java

Co-authored-by: jan-vcapgemini <59438728+jan-vcapgemini@users.noreply.github.com>
@raveendra11
Copy link
Contributor Author

raveendra11 commented May 23, 2025

To Make sure everything is checked before merging this PR, Believe I don't have permission to change these below statuses...

  • PR and issue(s) have suitable labels
  • Issue is set to In Progress and assigned to you or there is no issue (might happen for very small PRs)

@jan-vcapgemini jan-vcapgemini added the bugfix PR that fixes a bug issue label May 23, 2025
@jan-vcapgemini jan-vcapgemini moved this from 🆕 New to Team Review in IDEasy board May 23, 2025
Copy link
Contributor

@jan-vcapgemini jan-vcapgemini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@raveendra11 thanks for implementing my CR and signing the CLA. Looks good to me now. I've added another small CR for you to resolve then this PR can be merged. Looking forward to further PR's by you :)

Co-authored-by: jan-vcapgemini <59438728+jan-vcapgemini@users.noreply.github.com>
@jan-vcapgemini
Copy link
Contributor

To Make sure everything is checked before merging this PR, Believe I don't have permission to change these below statuses...

* PR and issue(s) have suitable labels

* Issue is set to In Progress and assigned to you or there is no issue (might happen for very small PRs)

I think these labels can only be added while the PR is being created.

@coveralls
Copy link
Collaborator

coveralls commented May 23, 2025

Pull Request Test Coverage Report for Build 15213793466

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.01%) to 67.795%

Files with Coverage Reduction New Missed Lines %
com/devonfw/tools/ide/tool/ide/IdeToolCommandlet.java 1 77.59%
Totals Coverage Status
Change from base Build 15213103217: -0.01%
Covered Lines: 8060
Relevant Lines: 11480

💛 - Coveralls

@raveendra11
Copy link
Contributor Author

To Make sure everything is checked before merging this PR, Believe I don't have permission to change these below statuses...

* PR and issue(s) have suitable labels

* Issue is set to In Progress and assigned to you or there is no issue (might happen for very small PRs)

I think these labels can only be added while the PR is being created.

Oh Okay! What should we do now?

Copy link
Contributor

@jan-vcapgemini jan-vcapgemini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Ready to merge.

@jan-vcapgemini
Copy link
Contributor

jan-vcapgemini commented May 23, 2025

To Make sure everything is checked before merging this PR, Believe I don't have permission to change these below statuses...

* PR and issue(s) have suitable labels

* Issue is set to In Progress and assigned to you or there is no issue (might happen for very small PRs)

I think these labels can only be added while the PR is being created.

Oh Okay! What should we do now?

I've added the label and assigned you to this PR. Everything is fine now... apart from the little merge conflict, please solve :)

@jan-vcapgemini
Copy link
Contributor

@raveendra11 Can you please also solve the merge conflict? It should be quite easy to fix. Will merge it then asap.

@raveendra11
Copy link
Contributor Author

To Make sure everything is checked before merging this PR, Believe I don't have permission to change these below statuses...

* PR and issue(s) have suitable labels

* Issue is set to In Progress and assigned to you or there is no issue (might happen for very small PRs)

I think these labels can only be added while the PR is being created.

Oh Okay! What should we do now?

I've added the label and assigned you to this PR. Everything is fine now... apart from the little merge conflict, please solve :)

Sure!

@raveendra11
Copy link
Contributor Author

Hi @jan-vcapgemini, Pls check now.

@jan-vcapgemini
Copy link
Contributor

Now github seems to have problems. Looks like I will have to merge this next week.
image
Sorry.

@raveendra11
Copy link
Contributor Author

No Problem, will see then.

@raveendra11
Copy link
Contributor Author

Now github seems to have problems. Looks like I will have to merge this next week. image Sorry.

It is up now.

@jan-vcapgemini jan-vcapgemini added this to the release:2025.05.002 milestone May 23, 2025
@jan-vcapgemini jan-vcapgemini merged commit 93b0078 into devonfw:main May 23, 2025
4 checks passed
@github-project-automation github-project-automation bot moved this from Team Review to ✅ Done in IDEasy board May 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix PR that fixes a bug issue

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

Link to settings documentation is broken

4 participants