#1307: Fixed link to correct documentation page.#1335
#1307: Fixed link to correct documentation page.#1335jan-vcapgemini merged 7 commits intodevonfw:mainfrom
Conversation
There was a problem hiding this comment.
@raveendra11 thank you for your PR. I've added a small CR. Please use our PR template (some to-dos f.e. adjusted CHANGELOG.adoc) were not applied. Also, please accept the CLA otherwise we can't merge this PR.
PS: I think you need to adjust your author information of your commit (needs to reflect your github username and e-mail) and do a force push to repair this PR.
git commit --amend --author="Author Name <email@address.com>" --no-edit
cli/src/main/java/com/devonfw/tools/ide/commandlet/AbstractUpdateCommandlet.java
Outdated
Show resolved
Hide resolved
…ateCommandlet.java Co-authored-by: jan-vcapgemini <59438728+jan-vcapgemini@users.noreply.github.com>
|
To Make sure everything is checked before merging this PR, Believe I don't have permission to change these below statuses...
|
jan-vcapgemini
left a comment
There was a problem hiding this comment.
@raveendra11 thanks for implementing my CR and signing the CLA. Looks good to me now. I've added another small CR for you to resolve then this PR can be merged. Looking forward to further PR's by you :)
Co-authored-by: jan-vcapgemini <59438728+jan-vcapgemini@users.noreply.github.com>
I think these labels can only be added while the PR is being created. |
Pull Request Test Coverage Report for Build 15213793466Details
💛 - Coveralls |
Oh Okay! What should we do now? |
jan-vcapgemini
left a comment
There was a problem hiding this comment.
LGTM. Ready to merge.
I've added the label and assigned you to this PR. Everything is fine now... apart from the little merge conflict, please solve :) |
|
@raveendra11 Can you please also solve the merge conflict? It should be quite easy to fix. Will merge it then asap. |
Sure! |
|
Hi @jan-vcapgemini, Pls check now. |
|
No Problem, will see then. |


This PR fixes #1307.
Implemented changes:
Checklist for this PR
Make sure everything is checked before merging this PR. For further info please also see
our DoD.
mvn clean testlocally all tests pass and build is successful#«issue-id»: «brief summary»(e.g.#921: fixed setup.bat). If no issue ID exists, title only.In Progressand assigned to you or there is no issue (might happen for very small PRs)with
internal