Skip to content

#1293 ensure core longpaths on windows#1359

Merged
jan-vcapgemini merged 15 commits intodevonfw:mainfrom
cthies-capgemini:feature/1293-ensure-core-longpaths-on-windows
Jun 6, 2025
Merged

#1293 ensure core longpaths on windows#1359
jan-vcapgemini merged 15 commits intodevonfw:mainfrom
cthies-capgemini:feature/1293-ensure-core-longpaths-on-windows

Conversation

@cthies-capgemini
Copy link
Contributor

@cthies-capgemini cthies-capgemini commented Jun 6, 2025

This PR fixes #1293 .

Implemented changes:

  • use GitContext.verifyGitInstalled to check if git is installed
  • make verifyGitInstalled public instead of private to allow this

cthies-capgemini and others added 15 commits May 15, 2025 13:07
Java does not understand "~" for home path

Co-authored-by: Jörg Hohwiller <hohwille@users.noreply.github.com>
…hs-on-windows' into feature/1293-ensure-core-longpaths-on-windows
…ore-longpaths-on-windows

# Conflicts:
#	CHANGELOG.adoc
@github-project-automation github-project-automation bot moved this to 🆕 New in IDEasy board Jun 6, 2025
@cthies-capgemini cthies-capgemini changed the title Feature/1293 ensure core longpaths on windows #1293 ensure core longpaths on windows Jun 6, 2025
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 15488457870

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 38 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.008%) to 67.734%

Files with Coverage Reduction New Missed Lines %
com/devonfw/tools/ide/tool/ide/IdeToolCommandlet.java 1 78.33%
com/devonfw/tools/ide/git/GitContextImpl.java 8 55.8%
com/devonfw/tools/ide/tool/IdeasyCommandlet.java 29 81.77%
Totals Coverage Status
Change from base Build 15437967653: -0.008%
Covered Lines: 8111
Relevant Lines: 11570

💛 - Coveralls

@jan-vcapgemini jan-vcapgemini self-assigned this Jun 6, 2025
@jan-vcapgemini jan-vcapgemini added bugfix PR that fixes a bug issue internal Nothing to be added to CHANGELOG, only internal story labels Jun 6, 2025
@jan-vcapgemini jan-vcapgemini moved this from 🆕 New to Team Review in IDEasy board Jun 6, 2025
@jan-vcapgemini jan-vcapgemini added this to the release:2025.06.001 milestone Jun 6, 2025
@jan-vcapgemini jan-vcapgemini marked this pull request as ready for review June 6, 2025 11:38
@jan-vcapgemini jan-vcapgemini self-requested a review June 6, 2025 11:38
Copy link
Contributor

@jan-vcapgemini jan-vcapgemini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cthies-capgemini thanks for providing a fix to detect git properly. LGTM.

@jan-vcapgemini
Copy link
Contributor

jan-vcapgemini commented Jun 6, 2025

I've tested your changes with following steps:

  1. Compiled a new ideasy.exe with graalvm
  2. Downloaded a fresh setup of IDEasy
  3. Replaced the ideasy.exe of my setup bin folder with my compiled one
  4. Removed all git related paths from my System and User paths.
  5. Rebooted the computer
  6. Renamed the C:\Program Files\Git\mingw64\bin\git.exe to git.exe1
  7. Removed IDE_ROOT and _ide/installation/bin from my User path.
  8. Deleted the maven folder from C:\Users<myuser>\projects_ide\software
  9. Run the setup of IDEasy

After the installation of IDEasy I've got following error message:

Git is not installed on your computer but required by IDEasy. Please download and install git:
https://git-scm.com/download/

I've also deleted the longpaths from my .gitconfig and it was re-added properly.

@jan-vcapgemini jan-vcapgemini merged commit 46a604d into devonfw:main Jun 6, 2025
4 checks passed
@github-project-automation github-project-automation bot moved this from Team Review to ✅ Done in IDEasy board Jun 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix PR that fixes a bug issue internal Nothing to be added to CHANGELOG, only internal story

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

Ensure git core.longpaths on Windows

3 participants