Skip to content

Comments

✨ Add initial support for Docker operations and enhance project structure#23

Merged
ChristophShyper merged 1 commit intomasterfrom
feature/docker
Mar 12, 2025
Merged

✨ Add initial support for Docker operations and enhance project structure#23
ChristophShyper merged 1 commit intomasterfrom
feature/docker

Conversation

@github-actions
Copy link
Contributor

📝 Brief description

⬆️ Bump boto3 from 1.37.7 to 1.37.8 (#19)
⬆️ Bump setuptools from 75.8.2 to 76.0.0
⬆️ Bump setuptools from 75.8.2 to 76.0.0 (#20)
⬆️ Bump boto3 from 1.37.8 to 1.37.10
⬆️ Bump boto3 from 1.37.8 to 1.37.10 (#21)
✨ Add initial support for Docker operations and enhance project structure

💻 Commits

  • 030776a - ChristophShyper - 2025-03-12 21:19:54
    ✨ Add initial support for Docker operations and enhance project structure
    Other improvements:

    • Updated utility functions in utils.py for better command execution and date handling.
    • Improved main menu navigation and service checks in velez.py.
    • Replaced setup.py with pyproject.toml for better build and installation processes.
    • Updated constant strings to capital case.
    • Added .pylintrc to suppress some warning from external libs.
    • Added Makefile for most important operations.
    • Added utils function for converting data sizes, printing tables or working with dates.
  • 66553b1 - Krzysztof Szyper - 2025-03-11 09:58:20
    | ⬆️ Bump boto3 from 1.37.8 to 1.37.10 (⬆️ Bump boto3 from 1.37.8 to 1.37.10 #21)
    | |
    | * 8d827a5 - dependabot[bot] - 2025-03-11 08:57:26
    |/ :arrow_up: Bump boto3 from 1.37.8 to 1.37.10
    | Bumps boto3 from 1.37.8 to 1.37.10.
    | - Release notes
    | - Commits
    |
    | ---
    | updated-dependencies:
    | - dependency-name: boto3
    | dependency-type: direct:production
    | update-type: version-update:semver-patch
    | ...
    |
    | Signed-off-by: dependabot[bot] support@github.com

  • f46507f - Krzysztof Szyper - 2025-03-11 09:56:31
    | ⬆️ Bump setuptools from 75.8.2 to 76.0.0 (⬆️ Bump setuptools from 75.8.2 to 76.0.0 #20)
    | |
    | * 88c67e8 - dependabot[bot] - 2025-03-10 20:01:56
    |/ :arrow_up: Bump setuptools from 75.8.2 to 76.0.0
    | Bumps setuptools from 75.8.2 to 76.0.0.
    | - Release notes
    | - Changelog
    | - Commits
    |
    | ---
    | updated-dependencies:
    | - dependency-name: setuptools
    | dependency-type: direct:production
    | update-type: version-update:semver-major
    | ...
    |
    | Signed-off-by: dependabot[bot] support@github.com

  • 8959166 - dependabot[bot] - 2025-03-08 09:41:05
    ⬆️ Bump boto3 from 1.37.7 to 1.37.8 (⬆️ Bump boto3 from 1.37.7 to 1.37.8 #19)
    ⬆️ Bump boto3 from 1.37.7 to 1.37.8

    Bumps boto3 from 1.37.7 to 1.37.8.


    updated-dependencies:

    • dependency-name: boto3
      dependency-type: direct:production
      update-type: version-update:semver-patch
      ...

    Signed-off-by: dependabot[bot] support@github.com
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

📁 Modified files

.pylintrc (new) | 3 +
Makefile (new) | 18 +
README.md | 64 ++-
pyproject.toml (new) | 38 ++
requirements.txt | 2 +
setup.py (gone) | 18 -
tests/test_docker_ops.py (new) | 24 ++
tests/test_file_ops.py (new) | 58 +++
tests/test_github_ops.py (new) | 192 +++++++++
tests/test_terragrunt_ops.py (new) | 104 +++++
tests/test_utils.py (new) | 41 ++
velez/docker_ops.py (new) | 778 +++++++++++++++++++++++++++++++++++++
velez/file_ops.py | 22 +-
velez/github_ops.py | 212 +++++-----
velez/terragrunt_ops.py | 207 +++++-----
velez/utils.py | 81 +++-
velez/velez.py | 62 ++-
17 files changed, 1652 insertions(+), 272 deletions(-)

⚠️ Additional information

  • Pushed to a branch with a proper name and provided proper commit message.
  • Provided a clear and concise description of what the issue is.

Check CONTRIBUTING.md and CODE_OF_CONDUCT.md for more information

…ture

Other improvements:
- Updated utility functions in `utils.py` for better command execution and date handling.
- Improved main menu navigation and service checks in `velez.py`.
- Replaced `setup.py` with `pyproject.toml` for better build and installation processes.
- Updated constant strings to capital case.
- Added `.pylintrc` to suppress some warning from external libs.
- Added `Makefile` for most important operations.
- Added utils function for converting data sizes, printing tables or working with dates.
@github-actions github-actions bot added the feature Adding a new feature label Mar 12, 2025
@ChristophShyper ChristophShyper merged commit f82f826 into master Mar 12, 2025
2 checks passed
@ChristophShyper ChristophShyper deleted the feature/docker branch March 12, 2025 20:49
@github-actions github-actions bot mentioned this pull request Mar 12, 2025
2 tasks
@ChristophShyper ChristophShyper requested a review from Copilot March 13, 2025 12:56
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request introduces initial support for Docker operations and improves the overall project structure. Key changes include:

  • New Docker operations support via additions to the framework and updates to the main menu.
  • Migration from setup.py to pyproject.toml with accompanying version bumps and project metadata updates.
  • Enhancements and standardizations across utility functions and tests, including improved naming conventions and expanded test coverage.

Reviewed Changes

Copilot reviewed 17 out of 17 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
pyproject.toml New build configuration replacing setup.py
README.md Updated documentation to include Docker operations and enhancements
velez/velez.py Added Docker menu support and updated main function to include version output
velez/docker_ops.py New module implementing Docker operations
velez/github_ops.py, terragrunt_ops.py, file_ops.py Standardized naming and constant updates for clarity
Various tests Additional tests for Docker and updates to existing tests
setup.py Removed in favor of pyproject.toml
Comments suppressed due to low confidence (1)

tests/test_docker_ops.py:12

  • [nitpick] The use of two separate @patch decorators on 'builtins.input' may not simulate sequential inputs as intended. Consider using a single patch with side_effect=['username', 'password'] to ensure both inputs are correctly provided.
@patch('builtins.input', return_value='username') followed by @patch('builtins.input', return_value='password')

args = parser.parse_args()

if args.version:
print(f"∀elez version: {version("velez")}")
Copy link

Copilot AI Mar 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using double quotes inside the f-string call to version() may cause a syntax error. Consider changing the inner quotes to single quotes, e.g.: print(f"∀elez version: {version('velez')}")

Suggested change
print(f"∀elez version: {version("velez")}")
print(f"∀elez version: {version('velez')}")

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature Adding a new feature

Development

Successfully merging this pull request may close these issues.

1 participant