Update handler.py #14
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The fetch_hacker_news_rss function has been renamed to fetch_bleeping_computer_rss and now uses the Bleeping Computer RSS feed URL - Renamed the function to reflect the new feed source.
Contributor
|
@Deadpool2000 thanks for the contribution!!! means a lot! this issue was to add the bleepingcomputer RSS feed. I still want the hacker news RSS feed as well. |
damienjburks
requested changes
Jan 28, 2025
- Main() function -Now fetches from both Bleeping Computer and Hacker News, combines the articles. - Handles Hacker News' 'GMT' timezone by converting it to '+0000', allowing correct date parsing. - After processing all articles, filters links to include only those from Bleeping Computer (based on URL) before sending to DynamoDB.
Deadpool2000
commented
Jan 28, 2025
Contributor
Author
Deadpool2000
left a comment
Deadpool2000
left a comment
There was a problem hiding this comment.
- Added Hacker News Feed
Contributor
Author
|
@damienjburks Please check changes. |
Contributor
|
@Deadpool2000 will check when i have a moment. |
damienjburks
requested changes
Jan 28, 2025
Contributor
damienjburks
left a comment
damienjburks
left a comment
There was a problem hiding this comment.
two more changes and then we should be good to go.
damienjburks
approved these changes
Jan 30, 2025
Contributor
damienjburks
left a comment
damienjburks
left a comment
There was a problem hiding this comment.
Great work on this @Deadpool2000 - appreciate your help 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fetch_hacker_news_rss function has been renamed to fetch_bleeping_computer_rss and now uses the Bleeping Computer RSS feed URL
Renamed the function to reflect the new feed source.
Ref of issue #2