Skip to content

Conversation

@vbakke
Copy link
Collaborator

@vbakke vbakke commented Sep 21, 2025

Let's try again. This time, creating a pull request (/merge request) into v4-dev. I decided to call this branch v4-dev so that we can reserve v4 to when we are ready to release.

@vbakke
Copy link
Collaborator Author

vbakke commented Sep 24, 2025

Added a new change, in the dependency graph:
image

Forgot to add support for dark mode, I just realised. I'll do that next...

@wurstbrot
Copy link
Collaborator

wurstbrot commented Sep 28, 2025

@vbakke I am not sure about "author" as an attribute due to data protection laws.
I added the others, see for example https://dsomm.owasp.org/assets/build-info.yaml

@wurstbrot
Copy link
Collaborator

At some point we might include a version in the data repository to the yaml. That is not so easy, because the activities.yaml/generated.yaml is not prepared for extra field (used to be in meta.yaml, which is moved to this repo)

@vbakke
Copy link
Collaborator Author

vbakke commented Sep 28, 2025

@vbakke I am not sure about "author" as an attribute due to data protection laws. I added the others, see for example https://dsomm.owasp.org/assets/build-info.yaml

The author is public in github anyway. But then again, it is not any need for that in my opinion, so that is fine to leave out author.

Just to verify: Is is regarding displaying version number and realse date of the DSOMM app, lets say on an About page, @wurstbrot ?

  • Will this file be produced whenever we merge to main?
  • And will this file also be included for peopler that run from docker, or clone the repo and run locally?

@vbakke
Copy link
Collaborator Author

vbakke commented Sep 28, 2025

At some point we might include a version in the data repository to the yaml. That is not so easy, because the activities.yaml/generated.yaml is not prepared for extra field (used to be in meta.yaml, which is moved to this repo)

EDIT: Moved my comment to a line in activities.yaml, to make a spearate thread that we may close:
#417 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants