Return an explicit error if getShardId is out of bounds#160
Merged
ghostdogpr merged 4 commits intoseries/2.xfrom Apr 22, 2025
Merged
Return an explicit error if getShardId is out of bounds#160ghostdogpr merged 4 commits intoseries/2.xfrom
ghostdogpr merged 4 commits intoseries/2.xfrom
Conversation
kajebiii
approved these changes
Apr 22, 2025
kajebiii
reviewed
Apr 22, 2025
entities/src/main/scala/com/devsisters/shardcake/Sharding.scala
Outdated
Show resolved
Hide resolved
kajebiii
approved these changes
Apr 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously you would just get a send timeout.
Specially for @yoohaemin who made
getShardIdreturn 0 😄