Skip to content

Prevent Shard Manager from processing until persistence succeeds #166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ghostdogpr merged 1 commit into from
Sep 19, 2025
Merged

Prevent Shard Manager from processing until persistence succeeds #166

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions manager/src/main/scala/com/devsisters/shardcake/ShardManager.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ class ShardManager(
_ <- ManagerMetrics.pods.increment
_ <- eventsHub.publish(ShardingEvent.PodRegistered(pod.address))
_ <- ZIO.when(state.unassignedShards.nonEmpty)(rebalance(rebalanceImmediately = false))
_ <- persistPods.forkDaemon
_ <- persistPods
} yield (),
onFalse = ZIO.logWarning(s"Pod $pod requested to register but is not alive, ignoring") *>
ZIO.fail(new RuntimeException(s"Pod $pod is not healthy, refusing to register"))
Expand Down Expand Up @@ -160,14 +160,15 @@ class ShardManager(
_ <- (Clock.sleep(config.rebalanceRetryInterval) *> rebalance(rebalanceImmediately)).forkDaemon
.when(failedPods.nonEmpty && rebalanceImmediately)
// persist state changes to Redis
_ <- persistAssignments.forkDaemon.when(areChanges)
_ <- persistAssignments.when(areChanges)
} yield ()
}

private def withRetry[E, A](zio: IO[E, A]): UIO[Unit] =
private def withRetry[A](zio: Task[A]): UIO[Unit] =
zio
.retry[Any, Any](Schedule.spaced(config.persistRetryInterval) && Schedule.recurs(config.persistRetryCount))
.ignore
.orDie
.unit

private def persistAssignments: UIO[Unit] =
withRetry(
Expand Down Expand Up @@ -260,7 +261,7 @@ object ShardManager {
ZIO.logWarningCause("Failed to persist pods on shutdown", cause)
)
}
_ <- shardManager.persistPods.forkDaemon
_ <- shardManager.persistPods
// rebalance immediately if there are unassigned shards
_ <- shardManager.rebalance(rebalanceImmediately = initialState.unassignedShards.nonEmpty).forkDaemon
// start a regular rebalance at the given interval
Expand Down