feat: support quickjs arm64 and linux and macOS #47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I do happen to have an arm64 linux device, I'll try to get this tested and merged soon! |
|
@devsnek ping |
gengjiawen
force-pushed
the
feat/quickjs
branch
from
48717f5 to
79f45a5
Compare
gengjiawen
changed the title
gengjiawen
force-pushed
the
feat/quickjs
branch
from
79f45a5 to
2e21020
Compare
|
ping |
devsnek
reviewed
Jul 31, 2023
devsnek
reviewed
Jul 31, 2023
gengjiawen
force-pushed
the
feat/quickjs
branch
2 times, most recently
from
109d29f to
8071482
Compare
|
PTAL |
devsnek
reviewed
Oct 27, 2023
| if (['darwin-arm64', 'darwin-x64', 'linux-arm64'].includes(platform)) { | ||
| return fetch('https://api.github.com/repos/napi-bindings/quickjs-build/releases') | ||
| .then((r) => r.json()) | ||
| .then((b) => b[0].tag_name); |
There was a problem hiding this comment.
i don't think this is inherently sorted the way you might expect. see graal for example.
Comment on lines
+48
to
+50
| if (platform === 'darwin-arm64') { | ||
| return `https://github.com/napi-bindings/quickjs-build/releases/download/${version}/qjs-macOS-arm64.zip`; | ||
| } |
There was a problem hiding this comment.
i think these could all be collapsed into
`https://github.com/napi-bindings/quickjs-build/releases/download/${version}/${getFilename()}.zip`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not fully tested since I don't have arm64 linux devices