113 story 1 22 fix view dismiss on swipe roomtabview#130
Merged
Conversation
Contributor
Author
|
Closes #113 |
Yalilix
requested changes
Nov 26, 2025
Comment on lines
37
to
45
| .sheet(isPresented: $showDetails) { | ||
| RoomDetailsSheetView(room: room, roomViewModel: roomViewModel) | ||
| .presentationDetents([.fraction(0.65), .fraction(0.75), .large], selection: $detent) | ||
| .presentationBackgroundInteraction(.enabled(upThrough: .large)) | ||
| .presentationCornerRadius(30) | ||
| RoomDetailsSheetView(room: room, roomViewModel: roomViewModel) { | ||
| showDetails = false | ||
| dismiss() | ||
| } | ||
| .presentationDetents([.fraction(0.65), .fraction(0.75), .large], selection: $detent) | ||
| .presentationBackgroundInteraction(.enabled(upThrough: .large)) | ||
| .presentationCornerRadius(30) | ||
| } |
Collaborator
There was a problem hiding this comment.
the sheet dismissal can be solved by adding this one line .interactiveDismissDisabled(true) to the sheet, as seen below.
.sheet(isPresented: $showDetails) {
RoomDetailsSheetView(room: room)
.environment(roomViewModel)
.presentationDetents([.fraction(0.65), .fraction(0.75), .large], selection: $detent)
.presentationBackgroundInteraction(.enabled(upThrough: .large))
.presentationCornerRadius(30)
.interactiveDismissDisabled(true)
}Remove the rest of the redundant code.
Contributor
Author
There was a problem hiding this comment.
Screen.Recording.2025-11-27.at.9.27.21.AM.mov
Doesn't work on my end.
Collaborator
There was a problem hiding this comment.
Oh my bad Muqueet. I misunderstood the ticket. but could u still leave this part in?
.sheet(isPresented: $showDetails) {
RoomDetailsSheetView(room: room)
.environment(roomViewModel)
.presentationDetents([.fraction(0.65), .fraction(0.75), .large], selection: $detent)
.presentationBackgroundInteraction(.enabled(upThrough: .large))
.presentationCornerRadius(30)
.interactiveDismissDisabled(true)
}It prevents the user from swiping down to dismiss just the sheet. Otherwise the pr lgtm!
xleonx0x
approved these changes
Dec 2, 2025
Contributor
xleonx0x
left a comment
xleonx0x
left a comment
There was a problem hiding this comment.
approving since yanlin said lgtm
avdn-dev
approved these changes
Dec 9, 2025
xleonx0x
deleted the
113-story-1-22-Fix-view-dismiss-on-swipe-roomtabview
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simulator.Screen.Recording.-.iPhone.17.Pro.-.2025-11-26.at.11.58.08.mov