Open
Conversation
…cate/delete one timetable synced, and history sync started
… eventDTO parsing.
… when setting default timetable. In convertClassToDTO, fixed reduce to have initial empty [] otherwise it breaks. Sent missing mapKey from FE to BE in createNewTimetable
…to sync-timetables
…e used. Deleted FriendsButton.tsx. And merged main
…handle screen display when a user is apart of no groups
…or duplicated classes
…erging-lucy-and-chanel-friends-activity
…r future subcom to continue
…l-friends-activity
lhvy
reviewed
Apr 14, 2025
| @Body('userId') userId: string, | ||
| @Body('timetable') timetable: TimetableDto, | ||
| ) { | ||
| console.log(userId + 'test '); |
Contributor
There was a problem hiding this comment.
Let's remove these logging lines
| } else { | ||
| newActivityCopy[activity] = null; | ||
| } | ||
| // newActivityCopy[activity] = classData !== null ? { ...classData } : null; |
| selectedClasses[courseCode][scrapedClassDTO.activity] = | ||
| classDataMap[courseCode].find((clz) => clz.classNo === classID) || null; | ||
| }); | ||
| console.log('selected classes conversion', selectedClasses); |
| const hasVisited = localStorage.getItem('visited'); | ||
|
|
||
| return ( | ||
| <ApolloProvider client={client}> |
Contributor
There was a problem hiding this comment.
Why did we lose the Apollo provider? (Not asking for it back, just something to look into...)
| import { Tooltip } from '@mui/material'; | ||
| import React from 'react'; | ||
|
|
||
| const emptyProfile = 'https://cdn.pixabay.com/photo/2015/10/05/22/37/blank-profile-picture-973460_960_720.png'; |
Contributor
There was a problem hiding this comment.
Is there a better way of providing this image - can we just bundle our own one?
Contributor
|
Use this code as inspiration, no need to merge / fully use it! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.