Skip to content

Commit 006a739

Browse files
committed
Merge branch 'develop' of github.com:devtron-labs/dashboard into feat/table-storybook
2 parents 5b06a24 + 48b2c4f commit 006a739

File tree

51 files changed

+609
-520
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

51 files changed

+609
-520
lines changed

.env

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -32,12 +32,9 @@ ENABLE_RESTART_WORKLOAD=false
3232
ENABLE_SCOPED_VARIABLES=true
3333
DEFAULT_CI_TRIGGER_TYPE_MANUAL=false
3434
ANNOUNCEMENT_BANNER_MSG=
35-
LOGIN_PAGE_IMAGE=
36-
LOGIN_PAGE_IMAGE_BG=
3735
HIDE_DEFAULT_CLUSTER=false
3836
GLOBAL_API_TIMEOUT=60000
3937
TRIGGER_API_TIMEOUT=60000
40-
LOGIN_DT_LOGO=
4138
SIDEBAR_DT_LOGO=
4239
ENABLE_EXTERNAL_ARGO_CD=false
4340
API_BATCH_SIZE=20
@@ -51,7 +48,6 @@ FEATURE_SCOPED_VARIABLE_ENVIRONMENT_LIST_ENABLE=false
5148
HIDE_NETWORK_STATUS_INTERFACE=true
5249
SYSTEM_CONTROLLER_LISTING_TIMEOUT=300000
5350
FEATURE_IMAGE_PROMOTION_ENABLE=false
54-
FEATURE_CD_MANDATORY_PLUGINS_ENABLE=true
5551
FEATURE_HIDE_USER_DIRECT_PERMISSIONS_FOR_NON_SUPER_ADMINS=false
5652
FEATURE_CONFIG_DRIFT_ENABLE=false
5753
FEATURE_PROMO_EMBEDDED_BUTTON_TEXT=
@@ -66,5 +62,5 @@ FEATURE_DEFAULT_LANDING_RB_ENABLE=false
6662
FEATURE_ACTION_AUDIOS_ENABLE=true
6763
FEATURE_APPLICATION_TEMPLATES_ENABLE=true
6864
FEATURE_CODE_MIRROR_ENABLE=false
69-
FEATURE_EXPERIMENTAL_THEMING_ENABLE=true
7065
FEATURE_DEFAULT_AUTHENTICATED_VIEW_ENABLE=false
66+
GATEKEEPER_URL=devtron.ai

.storybook/preview-head.html

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1 @@
1-
<link
2-
href="https://fonts.googleapis.com/css2?family=Open+Sans:ital,wght@0,300..800;1,300..800&display=swap"
3-
rel="stylesheet"
4-
/>
5-
<link href="https://fonts.googleapis.com/css2?family=Inconsolata&display=swap" rel="stylesheet" />
6-
<link href="https://fonts.googleapis.com/css2?family=Merriweather:wght@300;400;700;900&display=swap" rel="stylesheet" />
1+
<link rel="stylesheet" href="../index.css" />

.storybook/preview.tsx

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -38,9 +38,7 @@ const preview: Preview = {
3838
},
3939
decorators: (Story) => {
4040
if (!window._env_) {
41-
window._env_ = {
42-
FEATURE_EXPERIMENTAL_THEMING_ENABLE: true,
43-
} as customEnv
41+
window._env_ = {} as customEnv
4442
}
4543

4644
return (

config.md

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -30,9 +30,6 @@
3030
| HIDE_DEFAULT_CLUSTER | "true" | Hide default cluster |
3131
| HIDE_EXCLUDE_INCLUDE_GIT_COMMITS | "true" | Hide exclude include git commits |
3232
| HIDE_GITOPS_OR_HELM_OPTION | "false" | Enable GitOps and Helm option |
33-
| LOGIN_DT_LOGO | "" | Devtron logo for login page |
34-
| LOGIN_PAGE_IMAGE | "" | Login page image url |
35-
| LOGIN_PAGE_IMAGE_BG | "" | Login page image background color code |
3633
| ORGANIZATION_NAME | "" | Name of the organization |
3734
| POSTHOG_ENABLED | "true" | PostHog integration status |
3835
| POSTHOG_TOKEN | XXXXXXXX | PostHog API token |
@@ -48,6 +45,5 @@
4845
| TRIGGER_API_TIMEOUT | 60000 | Default timeout for all API requests for Trigger calls (Deploy artifacts, charts) in DASHBOARD |
4946
| FEATURE_HIDE_USER_DIRECT_PERMISSIONS_FOR_NON_SUPER_ADMINS | "true" | Would hide the user direct permissions for non-super admin users in User Permissions |
5047
| FEATURE_ACTION_AUDIOS_ENABLE | true | Would enable audios in dashboard |
51-
| FEATURE_EXPERIMENTAL_THEMING_ENABLE | true | Would enable theming in dashboard |
5248

5349
# DASHBOARD CONFIG SECRET

index.css

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,8 @@
1+
@import url('https://fonts.googleapis.com/css2?family=Open+Sans:ital,wght@0,300..800;1,300..800&display=swap');
2+
@import url('https://fonts.googleapis.com/css2?family=Inconsolata&display=swap');
3+
@import url('https://fonts.googleapis.com/css2?family=Merriweather:wght@300;400;700;900&display=swap');
4+
@import url('https://fonts.googleapis.com/css2?family=IBM+Plex+Mono:wght@400;500;600&display=swap');
5+
16
/*
27
* Although this is duplicated but this would help us with consistent loader in case
38
* the theme is same as the system theme.

index.html

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -18,15 +18,6 @@
1818
<html lang="en">
1919
<head>
2020
<meta charset="utf-8" />
21-
<link
22-
href="https://fonts.googleapis.com/css2?family=Open+Sans:ital,wght@0,300..800;1,300..800&display=swap"
23-
rel="stylesheet"
24-
/>
25-
<link href="https://fonts.googleapis.com/css2?family=Inconsolata&display=swap" rel="stylesheet" />
26-
<link
27-
href="https://fonts.googleapis.com/css2?family=Merriweather:wght@300;400;700;900&display=swap"
28-
rel="stylesheet"
29-
/>
3021
<link rel="stylesheet" href="./index.css" />
3122
<link rel="shortcut icon" href="/favicon.ico" />
3223
<script src="/dashboard/env-config.js"></script>

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
"private": true,
55
"homepage": "/dashboard",
66
"dependencies": {
7-
"@devtron-labs/devtron-fe-common-lib": "1.10.1-beta-2",
7+
"@devtron-labs/devtron-fe-common-lib": "1.10.9",
88
"@esbuild-plugins/node-globals-polyfill": "0.2.3",
99
"@rjsf/core": "^5.13.3",
1010
"@rjsf/utils": "^5.13.3",

src/App.tsx

Lines changed: 13 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -42,10 +42,12 @@ import {
4242
} from './components/common'
4343
import { UPDATE_AVAILABLE_TOAST_PROGRESS_BG, URLS } from './config'
4444
import { validateToken } from './services/service'
45+
import { getCentralAPIHealth } from './utils'
4546

4647
const NavigationRoutes = lazy(() => import('./components/common/navigation/NavigationRoutes'))
4748
const Login = lazy(() => import('./components/login/Login'))
4849
const GenericDirectApprovalModal = importComponentFromFELibrary('GenericDirectApprovalModal')
50+
const ActivateLicense = importComponentFromFELibrary('ActivateLicense', null, 'function')
4951

5052
export default function App() {
5153
const onlineToastRef = useRef(null)
@@ -159,15 +161,13 @@ export default function App() {
159161
}
160162

161163
useEffect(() => {
162-
if (typeof Storage !== 'undefined') {
163-
// TODO (Arun): Remove in next packet
164-
localStorage.removeItem('undefined')
165-
}
164+
166165
if (navigator.serviceWorker) {
167166
navigator.serviceWorker.addEventListener('controllerchange', handleControllerChange)
168167
}
169168
// If not K8S_CLIENT then validateToken otherwise directly redirect
170-
if (!window._env_.K8S_CLIENT) {
169+
// No need to validate token if on license auth page
170+
if (!window._env_.K8S_CLIENT && location.pathname !== CommonURLS.LICENSE_AUTH) {
171171
// By Passing validations for direct email approval notifications
172172
if (isDirectApprovalNotification) {
173173
redirectToDirectApprovalNotification()
@@ -178,6 +178,9 @@ export default function App() {
178178
setValidating(false)
179179
defaultRedirection()
180180
}
181+
182+
getCentralAPIHealth()
183+
181184
return () => {
182185
navigator.serviceWorker.removeEventListener('controllerchange', handleControllerChange)
183186
}
@@ -340,6 +343,11 @@ export default function App() {
340343
/>
341344
</Route>
342345
)}
346+
{ActivateLicense && (
347+
<Route path={CommonURLS.LICENSE_AUTH}>
348+
<ActivateLicense />
349+
</Route>
350+
)}
343351
{!window._env_.K8S_CLIENT && <Route path="/login" component={Login} />}
344352
<Route path="/" render={() => <NavigationRoutes />} />
345353
<Redirect

src/Pages/Applications/DevtronApps/Details/AppConfigurations/MainContent/DeploymentConfigCompare/DeploymentConfigCompare.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -459,7 +459,7 @@ export const DeploymentConfigCompare = ({
459459
classNamePrefix: 'compare-with-environment-selector',
460460
inputId: 'compare-with-environment-selector',
461461
name: 'compare-with-environment-selector',
462-
variant: SelectPickerVariantType.BORDER_LESS,
462+
variant: SelectPickerVariantType.COMPACT,
463463
value: getSelectPickerOptionByValue(compareEnvironmentSelectorOptions, chartRefId || compareWith, {
464464
label: BASE_CONFIGURATIONS.name,
465465
value: '',
@@ -497,7 +497,7 @@ export const DeploymentConfigCompare = ({
497497
classNamePrefix: 'environment-config-type-selector',
498498
inputId: `environment-config-type-selector-${isCompare ? 'compare' : 'current'}`,
499499
name: `environment-config-type-selector-${isCompare ? 'compare' : 'current'}`,
500-
variant: SelectPickerVariantType.BORDER_LESS,
500+
variant: SelectPickerVariantType.COMPACT,
501501
isSearchable: false,
502502
disableDescriptionEllipsis: true,
503503
value: getSelectPickerOptionByValue(

src/Pages/Applications/DevtronApps/Details/AppConfigurations/MainContent/DeploymentTemplate/DTChartSelector.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -253,7 +253,7 @@ const DTChartSelector = ({
253253
value={selectedOption}
254254
onChange={onSelectChartVersion}
255255
isSearchable={false}
256-
variant={SelectPickerVariantType.BORDER_LESS}
256+
variant={SelectPickerVariantType.COMPACT}
257257
size={ComponentSizeType.small}
258258
placeholder="Select version"
259259
isDisabled={migratedFrom === PipelineMigratedFromType.ARGO_APPLICATION}

0 commit comments

Comments
 (0)