Skip to content

Commit 4ac96b1

Browse files
committed
chore: nested breadcrumb
1 parent 94e9310 commit 4ac96b1

File tree

3 files changed

+13
-16
lines changed

3 files changed

+13
-16
lines changed

src/Pages/GlobalConfigurations/BuildInfra/BuildInfra.tsx

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -30,15 +30,15 @@ export const BuildInfra: FunctionComponent<BuildInfraProps> = ({ isSuperAdmin })
3030
return <ErrorScreenNotAuthorized />
3131
}
3232

33-
if (BuildInfraRouter) {
34-
return (
35-
<BuildInfraUtilityProvider>
36-
<BuildInfraRouter />
37-
</BuildInfraUtilityProvider>
38-
)
39-
}
40-
41-
return <ProfileForm />
33+
const content = BuildInfraRouter ? (
34+
<BuildInfraUtilityProvider>
35+
<BuildInfraRouter />
36+
</BuildInfraUtilityProvider>
37+
) : (
38+
<ProfileForm />
39+
)
40+
41+
return content
4242
}
4343

4444
export default BuildInfra

src/Pages/GlobalConfigurations/BuildInfra/ProfileForm.tsx

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -18,20 +18,17 @@ import React, { FunctionComponent, useMemo } from 'react'
1818

1919
import {
2020
APIResponseHandler,
21-
BUILD_INFRA_BREADCRUMB,
2221
BUILD_INFRA_TEXT,
2322
BuildInfraConfigForm,
2423
BuildInfraDescriptor,
2524
BuildInfraFooter,
2625
DEFAULT_PROFILE_NAME,
27-
useBreadcrumb,
2826
useBuildInfraForm,
2927
} from '@devtron-labs/devtron-fe-common-lib'
3028

3129
import './styles.scss'
3230

3331
const ProfileForm: FunctionComponent = () => {
34-
const { breadcrumbs } = useBreadcrumb(BUILD_INFRA_BREADCRUMB)
3532
const {
3633
isLoading,
3734
profileResponse,
@@ -68,7 +65,7 @@ const ProfileForm: FunctionComponent = () => {
6865
onSubmit={handleSubmit}
6966
>
7067
<div className="flexbox-col dc__gap-24 pt pr pb pl h-100 dc__overflow-auto">
71-
<BuildInfraDescriptor breadCrumbs={breadcrumbs} />
68+
<BuildInfraDescriptor />
7269

7370
<APIResponseHandler
7471
isLoading={isLoading}

src/components/scopedVariables/Descriptor.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ export default function Descriptor({ children, showUploadButton, readFile, searc
3232
}
3333
}
3434

35-
const additonalTippyContent = importComponentFromFELibrary('scopedVariablesHelpTippyText')
35+
const additionalTippyContent = importComponentFromFELibrary('scopedVariablesHelpTippyText')
3636

3737
return (
3838
<>
@@ -45,9 +45,9 @@ export default function Descriptor({ children, showUploadButton, readFile, searc
4545
<FeatureTitleWithInfo
4646
title={HEADER_TEXT.SCOPED_VARIABLES.title}
4747
renderDescriptionContent={() =>
48-
additonalTippyContent ? null : HEADER_TEXT.SCOPED_VARIABLES.description
48+
additionalTippyContent ? null : HEADER_TEXT.SCOPED_VARIABLES.description
4949
}
50-
additionalContent={additonalTippyContent?.()}
50+
additionalContent={additionalTippyContent?.()}
5151
docLink={HEADER_TEXT.SCOPED_VARIABLES.docLink}
5252
showInfoIconTippy
5353
/>

0 commit comments

Comments
 (0)