chore: remove numner option type

Author: arunjaindev

src/components/app/details/AboutAppInfoModal.tsx

@@ -24,9 +24,10 @@ import {
     ToastVariantType,
     ComponentSizeType,
     InfoBlock,
+    OptionType,
 } from '@devtron-labs/devtron-fe-common-lib'
 import { ReactComponent as Close } from '../../../assets/icons/ic-cross.svg'
-import { AboutAppInfoModalProps, NumberOptionType } from '../types'
+import { AboutAppInfoModalProps } from '../types'
 import { editApp } from '../service'
 import { projectChangeMessage } from './utils'
 
@@ -40,8 +41,8 @@ export default function AboutAppInfoModal({
     projectsList,
     appType,
 }: AboutAppInfoModalProps) {
-    const [projectsOptions, setProjectsOption] = useState<NumberOptionType[]>([])
-    const [selectedProject, setSelectedProject] = useState<NumberOptionType>()
+    const [projectsOptions, setProjectsOption] = useState<OptionType<number, string>[]>([])
+    const [selectedProject, setSelectedProject] = useState<OptionType<number, string>>()
     const [submitting, setSubmitting] = useState(false)
     const isJobOverview = appType === 'job'
 
@@ -67,7 +68,7 @@ export default function AboutAppInfoModal({
         )
     }
 
-    const handleProjectSelection = (selected: NumberOptionType): void => {
+    const handleProjectSelection = (selected: OptionType<number, string>): void => {
         setSelectedProject(selected)
     }
 

src/components/app/types.ts

@@ -32,11 +32,6 @@ import { APP_TYPE } from '@Config/constants'
 import { CreateAppFormStateType } from '@Pages/App/CreateAppModal/types'
 import { CDMaterialProps } from './details/triggerView/types'
 
-export interface NumberOptionType {
-    label: string
-    value: number
-}
-
 interface CDModalProps {
     cdPipelineId?: number
     triggerType?: string

src/components/v2/values/chartValuesDiff/ProjectUpdateModal.tsx

@@ -24,12 +24,12 @@ import {
     SelectPicker,
     ComponentSizeType,
     InfoBlock,
+    OptionType,
 } from '@devtron-labs/devtron-fe-common-lib'
 import { ReactComponent as Close } from '../../assets/icons/ic-close.svg'
 import { ProjectSelectorTypes } from './ChartValuesView.type'
 import { updateHelmAppProject } from '../../../charts/charts.service'
 import { ProjectChangeMessageList } from './constant'
-import { NumberOptionType } from '@Components/app/types'
 
 export default function ProjectUpdateModal({
     appId,
@@ -39,8 +39,8 @@ export default function ProjectUpdateModal({
     projectList,
     getAppMetaInfoRes,
 }: ProjectSelectorTypes) {
-    const [projectOptions, setProjectOptions] = useState<NumberOptionType[]>([])
-    const [selectedProject, setSelectedProject] = useState<NumberOptionType>()
+    const [projectOptions, setProjectOptions] = useState<OptionType<number, string>[]>([])
+    const [selectedProject, setSelectedProject] = useState<OptionType<number, string>>()
     const [isSubmitting, setSubmitting] = useState(false)
 
     useEffect(() => {
@@ -64,7 +64,7 @@ export default function ProjectUpdateModal({
         )
     }
 
-    const handleProjectSelection = (selected: NumberOptionType): void => {
+    const handleProjectSelection = (selected: OptionType<number, string>): void => {
         setSelectedProject(selected)
     }