-
Notifications
You must be signed in to change notification settings - Fork 55
fix: brotli static compression #2797
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
SATYAsasini
wants to merge
1
commit into
main
Choose a base branch
from
fix-brotli-static-compression
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,39 +1,43 @@ | ||
FROM node:20-alpine AS builder | ||
|
||
RUN apk add --no-cache git | ||
|
||
WORKDIR /app | ||
COPY package.json . | ||
COPY yarn.lock . | ||
|
||
COPY package.json yarn.lock . | ||
|
||
RUN apk add --no-cache git | ||
RUN yarn install --frozen-lockfile --network-timeout 600000 | ||
|
||
COPY src/ src | ||
COPY nginx.conf . | ||
COPY tsconfig.json . | ||
COPY vite.config.mts . | ||
COPY . . | ||
|
||
RUN echo `git rev-parse --short=9 HEAD` > health.html | ||
RUN echo `git rev-parse --short HEAD` > health.html && \ | ||
echo "" >> .env && \ | ||
echo "SENTRY_RELEASE_VERSION=dashboard@$(git rev-parse --short HEAD)" >> .env && \ | ||
yarn build | ||
|
||
RUN echo "" >> .env && \ | ||
echo "SENTRY_RELEASE_VERSION=dashboard@$(git rev-parse --short=9 HEAD)" >> .env | ||
FROM fholzer/nginx-brotli:v1.26.2 | ||
|
||
RUN yarn build | ||
# Install bash | ||
RUN apk add --no-cache bash shadow | ||
|
||
FROM nginx:stable | ||
RUN useradd -m -s /bin/bash devtron | ||
|
||
RUN useradd -ms /bin/bash devtron | ||
COPY --from=builder /app/dist/ /usr/share/nginx/html | ||
COPY ./nginx.conf /etc/nginx/nginx.conf | ||
COPY ./nginx-default.conf /etc/nginx/conf.d/default.conf | ||
|
||
WORKDIR /usr/share/nginx/html | ||
COPY --from=builder /app/./env.sh . | ||
COPY --from=builder /app/.env . | ||
COPY --from=builder /app/health.html . | ||
|
||
RUN chown -R devtron:devtron /usr/share/nginx/html | ||
# Make our shell script executable | ||
RUN chmod +x env.sh | ||
|
||
COPY --from=builder /app/env.sh . | ||
COPY --from=builder /app/.env . | ||
COPY --from=builder /app/health.html . | ||
|
||
RUN chown -R devtron:devtron /usr/share/nginx/html && \ | ||
chmod +x env.sh | ||
|
||
USER devtron | ||
CMD ["/bin/bash", "-c", "/usr/share/nginx/html/env.sh && nginx -g \"daemon off;\""] | ||
|
||
# Override the default ENTRYPOINT to allow shell scripting as fholzer/nginx-brotli has by-default entrypoint of nginx | ||
ENTRYPOINT ["/bin/bash", "-c"] | ||
|
||
CMD ["./env.sh && nginx -g 'daemon off;'"] | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] Use consistent quoting in the CMD instruction to prevent potential shell interpretation issues; consider using double quotes uniformly.
Copilot uses AI. Check for mistakes.