Skip to content

feat: NodeListSearchFilter - improve node search functionality with SelectPicker search #2833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
RohitRaj011 merged 22 commits into from
Jul 25, 2025
Merged

feat: NodeListSearchFilter - improve node search functionality with SelectPicker search #2833

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
223a708
feat: NodeListSearchFilter - improve node search functionality with S…
RohitRaj011 Jul 16, 2025
35647a5
Merge branch 'develop' of github.com:devtron-labs/dashboard into feat…
RohitRaj011 Jul 16, 2025
9f9b8c9
fix: update iteration over NODE_SEARCH_KEYS to use Object.values for …
RohitRaj011 Jul 16, 2025
257a408
fix: enhance keyboard navigation by focusing select picker after cust…
RohitRaj011 Jul 16, 2025
9b4f61c
feat: enhance NodeListSearchFilter with improved placeholder and keyb…
RohitRaj011 Jul 17, 2025
0e85959
fix: update NodeListSearchFilter and ResourceFilterOptions for improv…
RohitRaj011 Jul 17, 2025
0a4d245
fix: ResourceFilterOptions - update eventType size
RohitRaj011 Jul 18, 2025
26508ec
Merge branch 'develop' of github.com:devtron-labs/dashboard into feat…
RohitRaj011 Jul 18, 2025
534e9da
feat: NodeListSearchFilter - keydown navigation + code optimization
RohitRaj011 Jul 21, 2025
f5c1147
chore: add flag for canary rollout
arunjaindev Jul 21, 2025
ceb8082
chore: version bump
arunjaindev Jul 22, 2025
7c72afd
Merge pull request #2844 from devtron-labs/feat/canary-rollout-progress
arunjaindev Jul 22, 2025
3780546
feat: NodeListSearchFilter - integrate GroupedFilterSelectPicker
RohitRaj011 Jul 22, 2025
5c1020b
Merge branch 'hotfix-v0.39.0' of https://github.com/devtron-labs/dash…
arunjaindev Jul 22, 2025
2aa59f1
Merge pull request #2845 from devtron-labs/feat/sync-canary-progress
arunjaindev Jul 22, 2025
694dce9
feat: NodeListSearchFilter - move K8s version to GroupedFilterSelectP…
RohitRaj011 Jul 22, 2025
2a1b3ae
refactor: NodeListSearchFilter - search filter fix, style updates
RohitRaj011 Jul 23, 2025
4ba547c
fix: ConfigMapSecret - fix incorrect error state
RohitRaj011 Jul 24, 2025
1111aaa
fix: Permissions - Job workflows endpoint
RohitRaj011 Jul 24, 2025
633aa8b
Merge pull request #2849 from devtron-labs/fix/cm-secret-incorrect-er…
RohitRaj011 Jul 24, 2025
53747f5
refactor: style update
RohitRaj011 Jul 25, 2025
a5dda2c
Merge branch 'main' of github.com:devtron-labs/dashboard into feat/no…
RohitRaj011 Jul 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 0 additions & 12 deletions src/components/ResourceBrowser/Constants.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -325,23 +325,11 @@ export const NODE_LIST_HEADERS_TO_KEY_MAP: Record<(typeof NODE_LIST_HEADERS)[num
unschedulable: 'unschedulable',
} as const

export const NODE_SEARCH_KEY_OPTIONS = [
{ value: NODE_SEARCH_KEYS.NAME, label: 'Name' },
{ value: NODE_SEARCH_KEYS.LABEL, label: 'Label' },
{ value: NODE_SEARCH_KEYS.NODE_GROUP, label: 'Node group' },
] as const

export const DEFAULT_NODE_K8S_VERSION = {
label: 'K8s version: Any',
value: 'K8s version: Any',
}

export const NODE_SEARCH_KEY_PLACEHOLDER: Record<NODE_SEARCH_KEYS, string> = {
[NODE_SEARCH_KEYS.NAME]: 'Search by node name Eg. ip-172-31-2-152.us-east-2.compute.internal',
[NODE_SEARCH_KEYS.LABEL]: 'Search by key=value Eg. environment=production, tier=frontend',
[NODE_SEARCH_KEYS.NODE_GROUP]: 'Search by node group name Eg. mainnode',
}

export const NODE_SEARCH_KEYS_TO_OBJECT_KEYS: Record<
NODE_SEARCH_KEYS,
(typeof NODE_LIST_HEADERS_TO_KEY_MAP)[keyof typeof NODE_LIST_HEADERS_TO_KEY_MAP]
Expand Down
5 changes: 0 additions & 5 deletions src/components/ResourceBrowser/ResourceBrowser.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,11 +68,6 @@
display: grid;
grid-template-columns: auto 160px 1px 180px;
column-gap: 8px;

&__shortcut-key {
right: 10px;
top: 6px;
}
}

.resource-filter-options-container {
Expand Down
2 changes: 2 additions & 0 deletions src/components/ResourceBrowser/ResourceList/K8SResourceList.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,7 @@
updateSearchParams,
eventType = 'warning',
filteredRows,
rows,

Check failure on line 91 in src/components/ResourceBrowser/ResourceList/K8SResourceList.tsx

View workflow job for this annotation

GitHub Actions / ci 

Property 'rows' does not exist on type 'Pick<UseFiltersReturnType, "offset" | "searchKey" | "sortOrder" | "sortBy" | "handleSearch" | "clearFilters"> & K8sResourceListTableAdditionalProps & ... 4 more ... & Pick<...>'.
...restProps
}: K8SResourceListViewWrapperProps) => (
<div className="flexbox-col flex-grow-1 resource-list-container dc__overflow-hidden border__primary--left">
Expand All @@ -97,6 +98,7 @@
setVisibleColumns={setVisibleColumns}
allColumns={allColumns}
searchParams={restProps}
rows={rows}
/>
) : (
<ResourceFilterOptions
Expand Down
Loading
Loading