feat: remove duplication between EnvTrigger and TriggerView regarding Deploy and Bulk Deploy #2850
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arunjaindev
requested review from
vivek-devtron and
vikramdevtron
as code owners
…shboard into fix/cd-trigger
…shboard into fix/cd-trigger
…te components - Added ImageSelectionCTA component for handling image selection logic and UI. - Introduced MaterialListEmptyState component to manage and display empty states for material lists. - Updated DeployImageModal to integrate new components and improve state management. - Refactored utility functions to support new features and enhance code readability. - Improved type definitions for better TypeScript support and maintainability.
…avigation and layout
…state management and improve code readability
…nd responsiveness
- Added support for bulk deployment of images, including new tag selection options. - Introduced constants for bulk deployment image tags. - Updated DeployImageContent to handle bulk trigger scenarios and render appropriate UI elements. - Enhanced DeployImageHeader to accept a custom title prop for better flexibility. - Refactored rendering logic in DeployImageContent to improve readability and maintainability. - Added new types for better type safety and clarity in props. - Implemented error handling and empty state management for various deployment scenarios.
…sary loading states and props
…rror handling, prop defaults, and layout adjustments
…derImages functionality and enhance error handling
…ent handling and error messaging
…e tag handling and remove unused constants
…ageContent for improved image selection handling
…DeployImageContent for enhanced empty state handling
…e initialization and streamline image selection handling
…loyment handling and state management - Refactored BulkDeployModal to streamline image selection and deployment logic. - Integrated new utility functions for better handling of deployment window metadata and bulk CD details. - Updated service functions to fetch deployment window maps and handle API responses more effectively. - Improved type definitions for better clarity and maintainability. - Adjusted BulkTriggerSidebar to reflect changes in error handling for unauthorized access. - Cleaned up unused constants and imports across the affected files.
…nt and update dependency in DeployImageModal
…ployImageContent layout for better filter handling
… material handling and error management
… in deployment utilities
fix: issues modal not opening on click
…hboard into feat/common-cd-material
feat: common out render cd material from trigger view and env trigger…
…nto fix/cd-trigger
|
Some linked issues are invalid. Please update the issue links:\nIssue # in is not found or invalid (HTTP }404).\n |
…board into test/cd-trigger
… fix/cd-trigger
|
Some linked issues are invalid. Please update the issue links:\nIssue # in is not found or invalid (HTTP 404).\n |
…board into test/cd-trigger
vivek-devtron
previously approved these changes
Aug 11, 2025
…nto fix/cd-trigger
github-actions
bot
added
PR:Ready-to-Review
|
AbhishekA1509
approved these changes
Aug 18, 2025
vivek-devtron
approved these changes
Aug 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR refactors the CD trigger view components by removing duplication between CDMaterial and BulkCD components in EnvTriggerView and TriggerView. The main goal is to consolidate shared functionality into a new
DeployImageModalcomponent that can handle both individual and bulk deployment triggers.DeployImageModalcomponent structure to replace the duplicated CDMaterial componentFixes https://github.com/devtron-labs/sprint-tasks/issues/2502
Type of change
How Has This Been Tested?
QA
Checklist: