feat: command bar #2881
Merged
feat: command bar #2881
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nto fix/trigger-view
- Removed unused properties and methods from TriggerViewContext and TriggerViewState interfaces. - Updated TriggerViewContextType to simplify context management. - Cleaned up CIMaterialState and related interfaces. - Adjusted WorkflowProps to include openCIMaterialModal function. - Modified TriggerCINode to utilize openCIMaterialModal instead of context. - Enhanced processCIMaterialResponse to ensure type safety with CIMaterialType. - Updated getCIMaterialList function parameters for better clarity. - Removed unused route WEBHOOK_RECEIVED_PAYLOAD_ID from routes configuration.
… handling and commit history updates
…l handling and loading states
- Updated the logic to correctly set the `isSelected` property of the material to ensure the correct material state is maintained. - Modified the `setMaterialList` function to set `isMaterialLoading` for the selected material while leaving other properties unchanged, improving the loading state handling during material fetching.
… in BuildImageModal
…onstants in EnvTriggerView
- Refactored GitInfoMaterial to support bulk CI triggering, including handling of multiple applications and their respective states. - Introduced new service functions for triggering builds and managing errors. - Added utility functions for payload generation and validation of materials. - Updated TriggerBuildSidebar to render application-specific materials and cache options. - Implemented new types and interfaces for better type safety and clarity. - Enhanced user experience with informative tooltips and error handling for CI configurations.
…ecks in TriggerBuildSidebar
…ex values and enhance button functionality
…or better user experience
… related components
…ror handling and state management
…nto fix/trigger-view
…ror handling, state management, and UI updates
…egex value and improve BuildImageHeader layout
… Resources - add Review State
chore: update common-lib version
This reverts commit 2e91e64.
…resource-watcher-ui
… with keyboard shortcuts
AbhishekA1509
requested review from
vivek-devtron and
vikramdevtron
as code owners
There was a problem hiding this comment.
Pull Request Overview
This PR replaces the existing command bar implementation with a new CommandBar component. The change involves removing the old command infrastructure and implementing a modern command bar with improved navigation and recent action tracking.
- Removes the old command component architecture and related utilities
- Implements a new CommandBar component with React hooks and modern patterns
- Adds support for recent navigation actions and keyboard shortcuts
Reviewed Changes
Copilot reviewed 16 out of 17 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| src/components/common/navigation/Navigation.tsx | Removes old Command component integration and adds new CommandBar component |
| src/components/command/* | Removes entire old command implementation including types, utilities, and components |
| src/Pages/Shared/CommandBar/* | Adds new CommandBar implementation with TypeScript types, constants, and components |
| package.json | Removes flexsearch dependency that was used by the old command system |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
…mprove scroll behavior handling
…d shortcut handling and navigation
RohitRaj011
requested changes
Aug 14, 2025
| queryKey: ['recentNavigationActions'], | ||
| select: ({ result }) => | ||
| result.commandBar.recentNavigationActions.reduce<CommandBarGroupType>((acc, action) => { | ||
| const requiredGroup = structuredClone(NAVIGATION_GROUPS).find((group) => |
There was a problem hiding this comment.
Suggested change
| const requiredGroup = structuredClone(NAVIGATION_GROUPS).find((group) => | |
| const requiredGroup = NAVIGATION_GROUPS.find((group) => |
structuredClone is not required
There was a problem hiding this comment.
Mutating requiredGroup id which will mess up NAVIGATION_GROUPS const
| if (requiredGroup) { | ||
| const requiredItem = requiredGroup.items.find((item) => item.id === action.id) | ||
| requiredItem.id = `${RECENT_NAVIGATION_ITEM_ID_PREFIX}${action.id}` | ||
| acc.items.push(structuredClone(requiredItem)) |
There was a problem hiding this comment.
Suggested change
| acc.items.push(structuredClone(requiredItem)) | |
| acc.items.push(requiredItem) |
There was a problem hiding this comment.
Have removed in next PR
| acc.items.push(structuredClone(requiredItem)) | ||
| } | ||
| return acc | ||
| }, structuredClone(RECENT_ACTIONS_GROUP)), |
There was a problem hiding this comment.
Suggested change
| }, structuredClone(RECENT_ACTIONS_GROUP)), | |
| }, RECENT_ACTIONS_GROUP), |
revert: dc__truncate
decouple CD Trigger testing
…nto fix/cd-trigger
feat: remove duplication between EnvTrigger and TriggerView regarding Deploy and Bulk Deploy
RohitRaj011
approved these changes
Aug 18, 2025
vivek-devtron
approved these changes
Aug 18, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR replaces the existing command bar implementation with a new CommandBar component. The change involves removing the old command infrastructure and implementing a modern command bar with improved navigation and recent action tracking.
Removes the old command component architecture and related utilities
Implements a new CommandBar component with React hooks and modern patterns
Adds support for recent navigation actions and keyboard shortcuts
Fixes https://github.com/devtron-labs/sprint-tasks/issues/2539
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: