-
Notifications
You must be signed in to change notification settings - Fork 6
feat: add notifications icon in page header #957
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
The base branch was changed.
feat: Add SVG icon and expose hook.
chore: remove unused SVG icons and clean up Chart component props
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This pull request introduces a notifications feature for AI Recommendations, adds several new icons and navigation items, and performs cleanup of legacy AI Recommendations routes. The changes include updates to type definitions, a new notifications button in the page header for super admins, and enhancements to the API layer.
- Added notifications button to PageHeader for super admins to view AI Recommendations
- Introduced new icons (bell, bulb, piggybank, priority indicators, and others) and navigation types for audit logs and runbooks
- Removed legacy AI Recommendations routes and navigation items from constants
- Extended MainContext to support AIRecommendations component and added new environment variables
- Added useInfiniteQuery hook wrapper and Content-Type header to CoreAPI requests
Reviewed changes
Copilot reviewed 12 out of 26 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/index.ts | Added global types for HIDE_AUDIT_LOGS flag and ATHENA_ROOT path |
| src/Shared/Providers/MainContextProvider/types.ts | Extended MainContext with AIRecommendations component and isExpandedView flag for side panel |
| src/Shared/Hooks/useUserPreferences/types.ts | Added navigation IDs for audit logs and runbooks, removed ai-recommendations-overview |
| src/Shared/Components/Icon/Icon.tsx | Imported and registered 13 new icons (bell, bulb, priority indicators, etc.) |
| src/Shared/Components/Header/constants.ts | Added NOTIFICATIONS_TEMP_WINDOW_TITLE constant |
| src/Shared/Components/Header/PageHeader.tsx | Implemented notifications button with handler for super admins |
| src/Shared/Components/DocLink/constants.ts | Added SAMPLE_RUNBOOK_LINK documentation URL |
| src/Shared/Components/Charts/types.ts | Removed JSDoc comments from xScaleTitle and yScaleTitle properties |
| src/Common/Constants.ts | Added INFRASTRUCTURE_MANAGEMENT_AUDIT_LOGS and AUTOMATION_ENABLEMENT_RUNBOOKS routes, removed AI_RECOMMENDATIONS routes |
| src/Common/API/reactQueryHooks.ts | Added useInfiniteQuery hook wrapper with ResponseType support |
| src/Common/API/CoreAPI.ts | Added Content-Type application/json header to all API requests |
| src/Assets/IconV2/*.svg | Added 13 new SVG icon files for various UI elements |
| package.json & package-lock.json | Bumped version to 1.20.6-pre-48 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…son and package-lock.json
… from Window interface
…ageHeader component
…json and package-lock.json
… Icon component.
chore: Remove runbook icon, routes, and documentation links.
Description
This pull request introduces a new notifications feature for AI Recommendations and removes legacy AI Recommendations routes and navigation items. The main changes include adding a notifications button to the page header for super admins, updating context types to support this feature, and cleaning up unused constants and navigation IDs related to AI Recommendations.
AI Recommendations Notifications Feature:
PageHeadercomponent, visible to super admins, which opens a temporary window displaying AI Recommendations notifications. [1] [2] [3]ic-bell) for the notifications button in the icon map and imports. [1] [2]Context and Type Updates:
MainContexttype to include an optionalAIRecommendationscomponent, supporting the notifications feature. [1] [2] [3]PageHeaderto access new AI Recommendations properties.Cleanup of Legacy AI Recommendations Code:
Constants.tsand navigation item IDs. [1] [2] [3]1.20.6-pre-46inpackage.json.New Route Addition:
Constants.ts.Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist