Skip to content

Conversation

@AbhishekA1509
Copy link
Member

Description

This pull request introduces a new notifications feature for AI Recommendations and removes legacy AI Recommendations routes and navigation items. The main changes include adding a notifications button to the page header for super admins, updating context types to support this feature, and cleaning up unused constants and navigation IDs related to AI Recommendations.

AI Recommendations Notifications Feature:

  • Added a notifications button to the PageHeader component, visible to super admins, which opens a temporary window displaying AI Recommendations notifications. [1] [2] [3]
  • Integrated the new bell icon (ic-bell) for the notifications button in the icon map and imports. [1] [2]

Context and Type Updates:

  • Extended the MainContext type to include an optional AIRecommendations component, supporting the notifications feature. [1] [2] [3]
  • Updated context usage in PageHeader to access new AI Recommendations properties.

Cleanup of Legacy AI Recommendations Code:

  • Removed unused AI Recommendations routes and constants from Constants.ts and navigation item IDs. [1] [2] [3]
  • Bumped the package version to 1.20.6-pre-46 in package.json.

New Route Addition:

  • Added a new route for Automation Enablement Runbooks in Constants.ts.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas

vivek-devtron
vivek-devtron previously approved these changes Nov 10, 2025
@AbhishekA1509 AbhishekA1509 changed the base branch from develop-kubecon-ui to kubecon-2025 November 11, 2025 06:45
@AbhishekA1509 AbhishekA1509 dismissed vivek-devtron’s stale review November 11, 2025 06:45

The base branch was changed.

Copilot AI review requested due to automatic review settings December 5, 2025 06:54
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request introduces a notifications feature for AI Recommendations, adds several new icons and navigation items, and performs cleanup of legacy AI Recommendations routes. The changes include updates to type definitions, a new notifications button in the page header for super admins, and enhancements to the API layer.

  • Added notifications button to PageHeader for super admins to view AI Recommendations
  • Introduced new icons (bell, bulb, piggybank, priority indicators, and others) and navigation types for audit logs and runbooks
  • Removed legacy AI Recommendations routes and navigation items from constants
  • Extended MainContext to support AIRecommendations component and added new environment variables
  • Added useInfiniteQuery hook wrapper and Content-Type header to CoreAPI requests

Reviewed changes

Copilot reviewed 12 out of 26 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
src/index.ts Added global types for HIDE_AUDIT_LOGS flag and ATHENA_ROOT path
src/Shared/Providers/MainContextProvider/types.ts Extended MainContext with AIRecommendations component and isExpandedView flag for side panel
src/Shared/Hooks/useUserPreferences/types.ts Added navigation IDs for audit logs and runbooks, removed ai-recommendations-overview
src/Shared/Components/Icon/Icon.tsx Imported and registered 13 new icons (bell, bulb, priority indicators, etc.)
src/Shared/Components/Header/constants.ts Added NOTIFICATIONS_TEMP_WINDOW_TITLE constant
src/Shared/Components/Header/PageHeader.tsx Implemented notifications button with handler for super admins
src/Shared/Components/DocLink/constants.ts Added SAMPLE_RUNBOOK_LINK documentation URL
src/Shared/Components/Charts/types.ts Removed JSDoc comments from xScaleTitle and yScaleTitle properties
src/Common/Constants.ts Added INFRASTRUCTURE_MANAGEMENT_AUDIT_LOGS and AUTOMATION_ENABLEMENT_RUNBOOKS routes, removed AI_RECOMMENDATIONS routes
src/Common/API/reactQueryHooks.ts Added useInfiniteQuery hook wrapper with ResponseType support
src/Common/API/CoreAPI.ts Added Content-Type application/json header to all API requests
src/Assets/IconV2/*.svg Added 13 new SVG icon files for various UI elements
package.json & package-lock.json Bumped version to 1.20.6-pre-48

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@AbhishekA1509 AbhishekA1509 changed the base branch from kubecon-2025 to develop December 29, 2025 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants