Skip to content

refactor: remove unused PodMetadatum interface and update aggregateNo… #991

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
arunjaindev merged 12 commits into from
Jan 15, 2026
Merged

refactor: remove unused PodMetadatum interface and update aggregateNo… #991

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
03f1380
refactor: remove unused PodMetadatum interface and update aggregateNo…
arunjaindev Dec 23, 2025
0656aee
Merge pull request #992 from devtron-labs/fix/param-redirection
arunjaindev Dec 24, 2025
aa9104a
Merge branch 'hotfix-v0.43.0' of https://github.com/devtron-labs/devt…
arunjaindev Dec 26, 2025
b93fea5
chore: version bump
arunjaindev Dec 26, 2025
cde6936
chore: version bump
shivani170 Dec 29, 2025
33cc85e
Merge branch main into refactor/app-details
shivani170 Dec 29, 2025
1a35c4c
Merge branch 'main' into refactor/app-details
shivani170 Dec 29, 2025
37fefe9
Merge branch 'main' into refactor/app-details
shivani170 Dec 29, 2025
eac8b90
chore: version bump
arunjaindev Jan 5, 2026
d6daac4
refactor: remove margin from LoadingCard component
arunjaindev Jan 5, 2026
57dff89
fix: format values in SegmentedBarChart to use locale string represen…
arunjaindev Jan 5, 2026
88cdc5c
Merge branch 'main' of https://github.com/devtron-labs/devtron-fe-com…
arunjaindev Jan 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions src/Shared/Components/CICDHistory/types.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -642,13 +642,6 @@ export interface AggregatedNodes {
}
}

export interface PodMetadatum {
name: string
uid: string
containers: string[]
isNew: boolean
}

export const STATUS_SORTING_ORDER = {
[NodeStatus.Missing]: 1,
[NodeStatus.Degraded]: 2,
Expand Down
5 changes: 3 additions & 2 deletions src/Shared/Helpers.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ import {
ZERO_TIME_STRING,
} from '../Common'
import { getAggregator, GVKType } from '../Pages'
import { AggregatedNodes, PodMetadatum } from './Components'
import { AggregatedNodes } from './Components'
import { CUBIC_BEZIER_CURVE, UNSAVED_CHANGES_PROMPT_MESSAGE } from './constants'
import {
AggregationKeys,
Expand All @@ -63,6 +63,7 @@ import {
IntersectionOptions,
Node,
Nodes,
PodMetaData,
TargetPlatformItemDTO,
TargetPlatformsDTO,
WebhookEventNameType,
Expand Down Expand Up @@ -296,7 +297,7 @@ export const renderValidInputButtonTippy = (children: ReactElement) => (
</Tippy>
)

export function aggregateNodes(nodes: any[], podMetadata: PodMetadatum[]): AggregatedNodes {
export function aggregateNodes(nodes: any[], podMetadata: PodMetaData[]): AggregatedNodes {
const podMetadataMap = mapByKey(podMetadata, 'name')
// group nodes
const nodesGroup = nodes.reduce((agg, curr) => {
Expand Down
31 changes: 21 additions & 10 deletions src/Shared/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,13 +175,24 @@ export interface iNode extends Node {
status: string
pNode?: iNode
}

export interface HelmReleaseStatus {
status: string
message: string
description: string
}

export interface ResourceTree {
conditions: any
nodes: Node[]
newGenerationReplicaSet: string
nodes: Array<Node>
podMetadata: Array<PodMetaData>
status: string
podMetadata: PodMetaData[]
conditions?: any
releaseStatus?: HelmReleaseStatus
resourcesSyncResult?: Record<string, string>
hasDrift?: boolean
// lastSnapshotTime and wfrId are only available for isolated
lastSnapshotTime?: string
wfrId?: number
}

Expand All @@ -193,12 +204,6 @@ export enum AppType {
EXTERNAL_FLUX_APP = 'external_flux_app',
}

export interface HelmReleaseStatus {
status: string
message: string
description: string
}

interface MaterialInfo {
author: string
branch: string
Expand All @@ -222,7 +227,7 @@ export interface AppDetails {
appStoreChartName?: string
appStoreInstalledAppVersionId?: number
ciArtifactId?: number
deprecated?: false
deprecated?: boolean
environmentId?: number
environmentName: string
installedAppId?: number
Expand Down Expand Up @@ -258,6 +263,12 @@ export interface AppDetails {
FluxAppStatusDetail?: FluxAppStatusDetail
isPipelineTriggered?: boolean
releaseMode?: ReleaseMode
cdPipelineId?: number
triggerType?: string
parentEnvironmentName?: string
ciPipelineId?: number
trafficSwitched?: boolean
pcoId?: number
}

export interface ConfigDriftModalProps extends Required<Pick<AppDetails, 'appId'>> {
Expand Down