remove getResolvedConfigDataForValues

Author: prakash100198

api/restHandler/DeploymentConfigurationRestHandler.go

@@ -2,7 +2,6 @@ package restHandler
 
 import (
 	"context"
-	"encoding/json"
 	"fmt"
 	"github.com/devtron-labs/devtron/api/restHandler/common"
 	"github.com/devtron-labs/devtron/pkg/auth/authorisation/casbin"
@@ -91,20 +90,6 @@ func (handler *DeploymentConfigurationRestHandlerImpl) GetConfigData(w http.Resp
 		common.WriteJsonResp(w, err, nil, http.StatusBadRequest)
 		return
 	}
-	switch r.Method {
-	case http.MethodPost:
-		if r.ContentLength > 0 {
-			valuesPayload := &bean.ValuesDto{}
-			decoder := json.NewDecoder(r.Body)
-			err = decoder.Decode(valuesPayload)
-			if err != nil {
-				handler.logger.Errorw("error in decoding the request payload", "err", err, "requestBody", r.Body)
-				common.WriteJsonResp(w, err, nil, http.StatusBadRequest)
-				return
-			}
-			configDataQueryParams.Values = valuesPayload.Values
-		}
-	}
 
 	configDataQueryParams.UserId = userId
 	//RBAC START

api/router/DeploymentConfigRouter.go

@@ -26,6 +26,6 @@ func (router DeploymentConfigurationRouterImpl) initDeploymentConfigurationRoute
 		Methods("GET")
 	configRouter.Path("/data").
 		HandlerFunc(router.deploymentGroupRestHandler.GetConfigData).
-		Methods("GET", "POST")
+		Methods("GET")
 
 }

pkg/configDiff/DeploymentConfigurationService.go

@@ -142,33 +142,11 @@ func (impl *DeploymentConfigurationServiceImpl) GetAllConfigData(ctx context.Con
 		return impl.getConfigDataForCdRollback(ctx, configDataQueryParams, userHasAdminAccess)
 	case bean2.DeploymentHistory.ToString():
 		return impl.getConfigDataForDeploymentHistory(ctx, configDataQueryParams, userHasAdminAccess)
-	case bean2.ResolveData.ToString():
-		// this only supports resolution of deployment template data as of now
-		return impl.getResolvedConfigDataForValues(ctx, configDataQueryParams.Values, appId, envId)
 	}
 	// this would be the default case
 	return impl.getConfigDataForAppConfiguration(ctx, configDataQueryParams, appId, envId, clusterId, userHasAdminAccess)
 }
 
-func (impl *DeploymentConfigurationServiceImpl) getResolvedConfigDataForValues(ctx context.Context, values string, appId, envId int) (*bean2.DeploymentAndCmCsConfigDto, error) {
-	configDataDto := &bean2.DeploymentAndCmCsConfigDto{}
-	var err error
-	deploymentTemplateRequest := generateManifest.DeploymentTemplateRequest{
-		AppId:           appId,
-		RequestDataMode: generateManifest.Values,
-	}
-	if envId > 0 {
-		deploymentTemplateRequest.EnvId = envId
-	}
-	resolvedTemplate, _, err := impl.deploymentTemplateService.ResolveTemplateVariables(ctx, values, deploymentTemplateRequest)
-	if err != nil {
-		impl.logger.Errorw("error in getting resolved data for cm draft data ", "appId", appId, "err", err)
-		return nil, err
-	}
-
-	return configDataDto.WithDeploymentTemplateData(bean2.NewDeploymentAndCmCsConfig().WithResolvedValue(json.RawMessage(resolvedTemplate))), nil
-}
-
 func (impl *DeploymentConfigurationServiceImpl) getConfigDataForCdRollback(ctx context.Context, configDataQueryParams *bean2.ConfigDataQueryParams, userHasAdminAccess bool) (*bean2.DeploymentAndCmCsConfigDto, error) {
 	// wfrId is expected in this case to return the expected data
 	return impl.getConfigDataForDeploymentHistory(ctx, configDataQueryParams, userHasAdminAccess)

pkg/configDiff/bean/bean.go

@@ -175,7 +175,6 @@ type ConfigDataQueryParams struct {
 	UserId       int32  `schema:"-"`
 	WfrId        int    `schema:"wfrId"`
 	ConfigArea   string `schema:"configArea"`
-	Values       string `schema:"values"`
 }
 
 // FilterCriteria []string `schema:"filterCriteria"`