Skip to content

Commit 9bd8ef8

Browse files
committed
rename isSuccess to isFailed
1 parent ef60bc4 commit 9bd8ef8

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

pkg/eventProcessor/bean/workflowEventBean.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ type CdStageCompleteEvent struct {
4040
PluginRegistryArtifactDetails map[string][]string `json:"PluginRegistryArtifactDetails"`
4141
PluginArtifacts *PluginArtifacts `json:"pluginArtifacts"`
4242
IsArtifactUploaded bool `json:"isArtifactUploaded"`
43-
IsSuccess bool `json:"isSuccess"`
43+
IsFailed bool `json:"isFailed"`
4444
}
4545

4646
type UserDeploymentRequest struct {

pkg/eventProcessor/in/WorkflowEventProcessorService.go

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -172,10 +172,10 @@ func (impl *WorkflowEventProcessorImpl) SubscribeCDStageCompleteEvent() error {
172172
wfr.IsArtifactUploaded = cdStageCompleteEvent.IsArtifactUploaded
173173
if slices.Contains(cdWorkflowModelBean.WfrTerminalStatusList, wfr.Status) {
174174
impl.logger.Debugw("event received from ci runner, updating workflow runner status as succeeded", "savedWorkflowRunnerId", wfr.Id, "oldStatus", wfr.Status, "podStatus", wfr.PodStatus)
175-
if cdStageCompleteEvent.IsSuccess {
176-
wfr.Status = string(v1alpha1.NodeSucceeded)
177-
} else {
175+
if cdStageCompleteEvent.IsFailed {
178176
wfr.Status = string(v1alpha1.NodeFailed)
177+
} else {
178+
wfr.Status = string(v1alpha1.NodeSucceeded)
179179
}
180180
err = impl.cdWorkflowRunnerService.UpdateWfr(wfr, 1)
181181
if err != nil {
@@ -217,7 +217,7 @@ func (impl *WorkflowEventProcessorImpl) SubscribeCDStageCompleteEvent() error {
217217
}
218218

219219
func (impl *WorkflowEventProcessorImpl) handleCDStageCompleteEvent(triggerContext triggerBean.TriggerContext, cdStageCompleteEvent bean.CdStageCompleteEvent, wfr *cdWorkflowBean.CdWorkflowRunnerDto) {
220-
if !cdStageCompleteEvent.IsSuccess {
220+
if cdStageCompleteEvent.IsFailed {
221221
impl.logger.Debugw("event received from ci runner, updating workflow runner status as failed, not taking any action", "savedWorkflowRunnerId", wfr.Id, "oldStatus", wfr.Status, "podStatus", wfr.PodStatus)
222222
return
223223
}

0 commit comments

Comments
 (0)