ci pipeline get change

Author: kartik-579

api/restHandler/app/pipeline/configure/BuildPipelineRestHandler.go

@@ -565,26 +565,15 @@ func (handler *PipelineConfigRestHandlerImpl) GetCiPipeline(w http.ResponseWrite
 		common.WriteJsonResp(w, fmt.Errorf("unauthorized user"), "Unauthorized User", http.StatusForbidden)
 		return
 	}
-	ciConf, err := handler.getCiPipelineRespResolved(appId)
+	ciConf, err := handler.pipelineBuilder.GetCiPipelineRespResolved(appId)
 	if err != nil {
-		handler.Logger.Errorw("service err, GetCiPipeline", "err", err, "appId", appId)
+		handler.Logger.Errorw("service err, GetCiPipelineRespResolved", "appId", appId, "err", err)
 		common.WriteJsonResp(w, err, nil, http.StatusInternalServerError)
 		return
 	}
 	common.WriteJsonResp(w, err, ciConf, http.StatusOK)
 }
 
-func (handler *PipelineConfigRestHandlerImpl) getCiPipelineRespResolved(appId int) (*bean.CiConfigRequest, error) {
-	ciConf, err := handler.pipelineBuilder.GetCiPipeline(appId)
-	if err != nil {
-		return nil, err
-	}
-	if ciConf == nil || ciConf.Id == 0 {
-		err = &util.ApiError{Code: "404", HttpStatusCode: 200, UserMessage: "no data found"}
-	}
-	return ciConf, err
-}
-
 func (handler *PipelineConfigRestHandlerImpl) GetExternalCi(w http.ResponseWriter, r *http.Request) {
 	vars := mux.Vars(r)
 	appId, err := strconv.Atoi(vars["appId"])

pkg/pipeline/BuildPipelineConfigService.go

@@ -55,6 +55,8 @@ import (
 )
 
 type CiPipelineConfigService interface {
+	// GetCiPipelineRespResolved : gets the ci pipeline get response after resolving empty data response as expected by FE
+	GetCiPipelineRespResolved(appId int) (*bean.CiConfigRequest, error)
 	//GetCiPipeline : retrieves CI pipeline configuration (CiConfigRequest) for a specific application (appId).
 	// It fetches CI pipeline data, including pipeline materials, scripts, and associated configurations.
 	// It returns a detailed CiConfigRequest.
@@ -511,6 +513,17 @@ func (impl *CiPipelineConfigServiceImpl) getCiTemplateVariables(appId int) (ciCo
 	return ciConfig, err
 }
 
+func (impl *CiPipelineConfigServiceImpl) GetCiPipelineRespResolved(appId int) (*bean.CiConfigRequest, error) {
+	ciConf, err := impl.GetCiPipeline(appId)
+	if err != nil {
+		return nil, err
+	}
+	if ciConf == nil || ciConf.Id == 0 {
+		err = &util.ApiError{Code: "404", HttpStatusCode: 200, UserMessage: "no data found"}
+	}
+	return ciConf, err
+}
+
 func (impl *CiPipelineConfigServiceImpl) GetCiPipeline(appId int) (ciConfig *bean.CiConfigRequest, err error) {
 	ciConfig, err = impl.getCiTemplateVariables(appId)
 	if err != nil {