Skip to content

feat: bump default firefox version #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alan-agius4 merged 1 commit into from
Oct 9, 2025
Merged

feat: bump default firefox version #30

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions browsers/private/update-tool/index.mts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,12 +108,7 @@ async function downloadMilestonesAndWriteVersionsFiles({
}

const allVersions = [...Object.keys(versions)];

// Since 136.0 firefox in RBE causes `Protocol error (session.new): Target closed` errors
// This can be tested/debugged via `pnpm bazel test //packages/core/test/acceptance/selectorless:selectorless_web_firefox --config=remote --google_default_credentials`
// in the angular/angular repo.
const defaultVersion =
browser === 'firefox' ? '135.0' : allVersions[allVersions.length - 1];
const defaultVersion = allVersions[allVersions.length - 1];

// Write both the JSON and the `.bzl` file. They both contain the same
// versions list. The `.bzl` file just has some additional syntax.
Expand Down
2 changes: 1 addition & 1 deletion browsers/private/versions/firefox.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
DO NOT EDIT. Generated by //browsers/private/update-tool:update-tool.
"""

DEFAULT_VERSION = "135.0"
DEFAULT_VERSION = "143.0"

VERSIONS = {
"129.0": {
Expand Down
Loading