Fix assertion error for arrays with lots of zeros.#79
Open
jenni-westoby wants to merge 1 commit intodeweylab:masterfrom
Open
Fix assertion error for arrays with lots of zeros.#79jenni-westoby wants to merge 1 commit intodeweylab:masterfrom
jenni-westoby wants to merge 1 commit intodeweylab:masterfrom
Conversation
The logic for sampling arrays fails when most of the array is zero. We fix this by sampling uniformly from the indices into the array, as suggested by the comment in simul.h.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The logic for sampling arrays fails when most of the array is zero.
We fix this by sampling uniformly from the indices into the array,
as suggested by the comment in simul.h.