Fix builtin connector example #184
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Simon Bein <[email protected]>
Signed-off-by: Simon Bein <[email protected]>
Signed-off-by: Simon Bein <[email protected]>
SimonTheLeg
force-pushed
the
fix-local-connectors
branch
from
d6ddf5a to
128a6f6
Compare
rogerogers
reviewed
Dec 4, 2024
|
|
||
| ```shell | ||
| curl -L -X POST 'http://localhost:8080/dex/token' \ | ||
| -H 'Authorization: Basic cHVibGljLWNsaWVudAo=' \ # base64 encoded: public-client |
There was a problem hiding this comment.
Basic auth is also acceptable. The current content is wrong.
Should be
-H 'Authorization: Basic cHVibGljLWNsaWVudDo=' \
rogerogers
reviewed
Dec 4, 2024
|
|
||
| ```shell | ||
| curl -L -X POST 'http://localhost:8080/dex/token' \ | ||
| -H 'Authorization: Basic cHJpdmF0ZS1jbGllbnQ6YXBwLXNlY3JldAo=' \ # base64 encoded: private-client:app-secret |
There was a problem hiding this comment.
Should be
-H 'Authorization: Basic cHJpdmF0ZS1jbGllbnQ6YXBwLXNlY3JldA=' \
private-client:app-secret
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in detail in #183, I was not able to get the builtin connector example to work. This PR includes two quality of life fixes and an update to the curl commands. It fixes both the wrongly set password and also gets rid of the need for the base64 header, which also I think has a syntactic mistake by not properly using a
:character.Fixes: #183