Skip to content

Conversation

@FDUTCH
Copy link
Contributor

@FDUTCH FDUTCH commented Dec 25, 2025

not every knockback is a result of player been punched, so I think we need ability to control every knockback

@Studgi
Copy link
Contributor

Studgi commented Dec 25, 2025

I suggest combining HandleEntityAttack and this handler into a single version. Perhaps also specifying the cause of the knockback (e.g. KnockBackCause)

@xNatsuri xNatsuri added the feature New feature or request label Dec 25, 2025
@FDUTCH
Copy link
Contributor Author

FDUTCH commented Dec 26, 2025

I suggest combining HandleEntityAttack and this handler into a single version. Perhaps also specifying the cause of the knockback (e.g. KnockBackCause)

I like the idea of having as much information as possible when handling events, but it seems that the guys here prefer simplicity, so I think we can avoid adding KnockBackCause (as I described in discord, there is a way to get knockback cause)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants