handle tsv gzip responses, e.g. salesReports #5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4.
@tkafka Do you have an opinion of whether we should return the raw TSV text or whether we should convert the TSV to a JSON object first?
This PR returns a JSON object in a fake
{data: []}object, like this:That way, you can write code like this:
But maybe I should just return the raw TSV as a giant string. Or at least not make a fake
datakey, just return the report results inline.What do you think?