Skip to content

test: Improve test failure messages for isWritable #106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dfed merged 7 commits into from
Sep 11, 2025
Merged

test: Improve test failure messages for isWritable #106

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
1678428
test: Improve test failure messages for isWritable
philipphofmann Sep 10, 2025
bdeb45c
Update Tests/CacheAdvanceTests/CacheAdvanceTests.swift
philipphofmann Sep 11, 2025
92715f1
Update Tests/CacheAdvanceTests/CacheAdvanceTests.swift
philipphofmann Sep 11, 2025
4deb21d
Update Tests/CacheAdvanceTests/CacheAdvanceTests.swift
philipphofmann Sep 11, 2025
c4949bb
Update Tests/CacheAdvanceTests/CacheAdvanceTests.swift
philipphofmann Sep 11, 2025
e509122
test: Replace guard let with XCTUnwrap (#107)
philipphofmann Sep 10, 2025
f633117
Merge branch 'main' into test/improve-test-message
philipphofmann Sep 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions Tests/CacheAdvanceTests/CacheAdvanceTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,7 +231,7 @@ struct CacheAdvanceTests {
#expect(try originalCache.isWritable())

let sut = try createCache(overwritesOldMessages: false)
#expect(try sut.isWritable())
#expect(try sut.isWritable(), "Identical cache should be writable")
}

@Test
Expand All @@ -243,7 +243,7 @@ struct CacheAdvanceTests {
try originalHeader.synchronizeHeaderData()

let sut = try createCache(overwritesOldMessages: false)
#expect(try !sut.isWritable())
#expect(try !sut.isWritable(), "Cache with different version should not be writable")
}

@Test
Expand All @@ -255,7 +255,7 @@ struct CacheAdvanceTests {
sizedToFit: TestableMessage.lorumIpsum.dropLast(),
overwritesOldMessages: false
)
#expect(try !sut.isWritable())
#expect(try !sut.isWritable(), "Cache with different maximum size should not be writable")
}

@Test
Expand All @@ -264,7 +264,7 @@ struct CacheAdvanceTests {
#expect(try originalCache.isWritable())

let sut = try createCache(overwritesOldMessages: true)
#expect(try !sut.isWritable())
#expect(try !sut.isWritable(), "Cache with different overwriting policy should not be writable")
}

@Test
Expand Down