Skip to content

Conversation

@dfed
Copy link
Owner

@dfed dfed commented Dec 5, 2025

Resolves #188 by not throwing an error when compiler errors are detected. We want to exit 0 such that users' compilers can highlight the syntax error that breaks our parsing rather than encountering an issue where SafeDI incorrectly tells the user that a type does not exist that does exist.

@dfed dfed self-assigned this Dec 5, 2025
@codecov
Copy link

codecov bot commented Dec 5, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.90%. Comparing base (845616e) to head (0a14c9c).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #189   +/-   ##
=======================================
  Coverage   99.90%   99.90%           
=======================================
  Files          32       32           
  Lines        3231     3257   +26     
=======================================
+ Hits         3228     3254   +26     
  Misses          3        3           
Files with missing lines Coverage Δ
Sources/SafeDICore/Visitors/FileVisitor.swift 100.00% <100.00%> (ø)
Sources/SafeDITool/SafeDITool.swift 99.55% <100.00%> (+0.04%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dfed dfed marked this pull request as ready for review December 5, 2025 09:02
@dfed dfed merged commit 0381a95 into main Dec 5, 2025
24 checks passed
@dfed dfed deleted the dfed--parsing-fail-188 branch December 5, 2025 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve handling of unexpected nodes in parser

2 participants