Skip to content

Use NSLock for better performance #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dfed wants to merge 1 commit into from
Closed

Use NSLock for better performance #59

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 8 additions & 20 deletions Sources/AsyncQueue/Utilities/Delivery.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
// SOFTWARE.

import Dispatch
import Foundation

actor Delivery<Success: Sendable, Failure: Error> {
func sendValue(_ value: Success) {
Expand Down Expand Up @@ -115,29 +115,17 @@ extension Delivery where Failure == any Error {
// MARK: - Locked

// We'd use `OSAllocatedUnfairLock` or `Mutex` but the minimum supported version is much higher than what we support.
private struct Locked<State>: @unchecked Sendable {
private final class Locked<State>: @unchecked Sendable {
init(value: State) {
container = .init(value: value)
unsafeValue = value
}

func withLock<R>(_ body: @Sendable (inout State) throws -> R) rethrows -> R where R: Sendable {
try lockQueue.sync {
var value = container.unsafeValue
let returnValue = try body(&value)
container.unsafeValue = value
return returnValue
}
lock.lock()
defer { lock.unlock() }
return try body(&unsafeValue)
}

private let container: UnsafeContainer

private final class UnsafeContainer: @unchecked Sendable {
init(value: State) {
unsafeValue = value
}

var unsafeValue: State
}
private var unsafeValue: State
private let lock = NSLock()
}

private let lockQueue = DispatchQueue(label: "LockedValue.lockQueue", target: DispatchQueue.global())