Skip to content

Warn when direct package reference is unused #121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
stan-sz wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Warn when direct package reference is unused #121

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions src/Tests/E2ETests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -306,6 +306,17 @@ public Task UnusedPackageReference()
});
}

[TestMethod]
public Task UnusedPackageReferenceWithSdk()
{
return RunMSBuildAsync(
projectFile: "Test/Test.csproj",
expectedWarnings:
[
new Warning("RT0003: PackageReference Moq can be removed", "Test/Test.csproj")
]);
}

[TestMethod]
public Task UnusedPackageReferenceNoWarn()
{
Expand Down
9 changes: 9 additions & 0 deletions src/Tests/TestData/UnusedPackageReferenceWithSdk/Test/Test.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
using Castle.Core.Logging;

namespace Test
{
public class Foo
{
public static ILogger Logger() => NullLogger.Instance;
}
}
12 changes: 12 additions & 0 deletions src/Tests/TestData/UnusedPackageReferenceWithSdk/Test/Test.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
<Project Sdk="MSTest.Sdk">

<PropertyGroup>
<TargetFramework>net8.0</TargetFramework>
<ExplicitUsings>enable</ExplicitUsings>
</PropertyGroup>

<ItemGroup>
<PackageReference Include="Moq" Version="4.20.72" />
</ItemGroup>

</Project>
Loading