Skip to content

Conversation

@spoorcc
Copy link
Contributor

@spoorcc spoorcc commented Jan 4, 2026

softprops/action-gh-release creates untagged releases

Summary by CodeRabbit

  • Chores
    • Switched release creation and artifact upload to the GitHub CLI, creating draft releases and uploading artifacts via CLI commands.
    • Ensured tags, titles, release notes and license attachment are preserved.
    • Added explicit tag fetching to workflows for full repository context before release.
    • Minor workflow labeling updates for clarity (step names/emoji).

✏️ Tip: You can customize this high-level summary in your review settings.

softprops/action-gh-release creates untagged releases
@spoorcc spoorcc added the development Tools for development label Jan 4, 2026
@coderabbitai
Copy link

coderabbitai bot commented Jan 4, 2026

Warning

Rate limit exceeded

@spoorcc has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 5 minutes and 1 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between c21fe06 and 397fa28.

📒 Files selected for processing (1)
  • .github/workflows/release.yml

Walkthrough

Replace use of the softprops/action-gh-release GitHub Action with direct gh CLI invocations for creating draft releases and uploading release artifacts; checkout fetch-depth/fetch-tags options were also added to support tag handling. (49 words)

Changes

Cohort / File(s) Summary
Release workflow
.github/workflows/release.yml
Added fetch-depth: 0 and fetch-tags: true to actions/checkout; renamed step to "Create draft release"; replaced softprops/action-gh-release with a gh release create shell invocation (uses --draft, --notes-file, tag/title handling) and added an explicit git fetch --tags; attaches LICENSE.
Build workflow artifact uploads
.github/workflows/build.yml
Replaced softprops/action-gh-release upload steps with gh release upload CLI calls (uses --clobber) for installer and package artifacts (lists package files and cdx.json), updated step naming/labels to reflect CLI-based uploads.

Sequence Diagram(s)

(omitted)

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

Suggested labels

github_actions

Suggested reviewers

  • ben-edna

Pre-merge checks

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Use official github tool for creating release' directly aligns with the main objective of replacing softprops/action-gh-release with the official GitHub CLI tool for release creation.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 288ae1f and d959df2.

📒 Files selected for processing (1)
  • .github/workflows/build.yml
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-12-25T23:53:05.742Z
Learnt from: spoorcc
Repo: dfetch-org/dfetch PR: 861
File: .github/workflows/build.yml:120-125
Timestamp: 2025-12-25T23:53:05.742Z
Learning: When building macOS PKG installers with fpm in CI, account for the known issue (fpm #1996) where --prefix can be duplicated (e.g., /opt/dfetch becomes /opt/dfetch/opt/dfetch). In the workflow at .github/workflows/build.yml, verify install paths and PATH entries do not assume a single-prefix layout. Adjust packaging scripts or fpm arguments to normalize the final install location and update PATH references accordingly. Add a test step to validate the expected runtime paths after installation.

Applied to files:

  • .github/workflows/build.yml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (20)
  • GitHub Check: docs / Documentation
  • GitHub Check: docs / Landing page
  • GitHub Check: run / test-cygwin
  • GitHub Check: prep-release / prepare-release
  • GitHub Check: test / test
  • GitHub Check: build / build (windows-latest)
  • GitHub Check: build / build (ubuntu-latest)
  • GitHub Check: build / build (macos-latest)
  • GitHub Check: Codacy Static Code Analysis
  • GitHub Check: run / run (windows-latest, 3.12)
  • GitHub Check: run / run (macos-latest, 3.9)
  • GitHub Check: run / run (windows-latest, 3.13)
  • GitHub Check: run / run (windows-latest, 3.11)
  • GitHub Check: run / run (windows-latest, 3.10)
  • GitHub Check: run / run (windows-latest, 3.9)
  • GitHub Check: run / run (windows-latest, 3.14)
  • GitHub Check: run / run (macos-latest, 3.14)
  • GitHub Check: run / test-cygwin
  • GitHub Check: test / test
  • GitHub Check: DevContainer Build & Test
🔇 Additional comments (2)
.github/workflows/build.yml (2)

213-216: LGTM! Clean migration to gh CLI.

The wheel upload step correctly uses gh release upload with the dist/* glob pattern. Since this job runs only on ubuntu-latest, there are no shell compatibility concerns.

Note: The --clobber flag will overwrite existing files with the same name in the release, which is appropriate for re-running builds but means any manual artifact edits would be lost.


107-114: GitHub CLI is pre-installed and --clobber works as documented.

The gh CLI is pre-installed on all GitHub-hosted runners (ubuntu-latest, macos-latest, windows-latest) and updated weekly. The --clobber flag works as documented to overwrite existing release assets with the same name. No action required.

Otherwise gh release create will create an untagged release
@spoorcc spoorcc merged commit 942039e into main Jan 4, 2026
38 checks passed
@spoorcc spoorcc deleted the fix-release-mechanism branch January 4, 2026 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

development Tools for development

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants