Skip to content

Revert "Use official github tool for creating release" #913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
spoorcc merged 10 commits into from
Jan 4, 2026
Merged

Revert "Use official github tool for creating release" #913

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
5974456
Revert "No need to fetch tag etc, see comment"
spoorcc Jan 4, 2026
c872b2a
Revert "Setup python before checkout to not interfere with repo"
spoorcc Jan 4, 2026
0728a12
Revert "Overwrite the local tag"
spoorcc Jan 4, 2026
b991c2b
Revert "Refresh just before creating release"
spoorcc Jan 4, 2026
d8700a0
Revert "Verify the tag"
spoorcc Jan 4, 2026
d94c30d
Revert "Make sure gh release operates on correct repo"
spoorcc Jan 4, 2026
b5097f7
Revert "--clobber should be last arg"
spoorcc Jan 4, 2026
1a13207
Revert "Make sure we have tag info when creating release"
spoorcc Jan 4, 2026
54163d5
Revert "Use official gh release tool for uploading artifacts as well"
spoorcc Jan 4, 2026
8972196
Revert "Use official github tool"
spoorcc Jan 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 19 additions & 12 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,17 +102,19 @@ jobs:
build/dfetch-package/*.msi
build/dfetch-package/*.cdx.json

- name: Upload installer to release ⬆️
- name: Upload installer to release
if: ${{ inputs.release_id }}
shell: bash
run: gh release upload \
"${{ inputs.release_id }}" \
build/dfetch-package/*.deb \
build/dfetch-package/*.rpm \
build/dfetch-package/*.pkg \
build/dfetch-package/*.msi \
build/dfetch-package/*.cdx.json \
--clobber
uses: softprops/action-gh-release@5122b4edc95f85501a71628a57dc180a03ec7588 # v2.5.0
with:
tag_name: ${{ inputs.release_id }}
files: |
build/dfetch-package/*.deb
build/dfetch-package/*.rpm
build/dfetch-package/*.pkg
build/dfetch-package/*.msi
build/dfetch-package/*.cdx.json
draft: true
preserve_order: true
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

Expand Down Expand Up @@ -211,7 +213,12 @@ jobs:
with:
name: python-package-distributions
path: dist/
- name: Upload artifacts to release ⬆️
run: gh release upload "${{ inputs.release_id }}" dist/* --clobber
- name: Upload artifacts to release
uses: softprops/action-gh-release@5122b4edc95f85501a71628a57dc180a03ec7588 # v2.5.0
with:
tag_name: ${{ inputs.release_id }}
files: dist/*
draft: true
preserve_order: true
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
23 changes: 9 additions & 14 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,13 +24,10 @@ jobs:
- uses: step-security/harden-runner@20cf305ff2072d973412fa9b1e3a4f227bda3c76 # v2.14.0
with:
egress-policy: audit
- uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8 # v6.0.1
- uses: actions/setup-python@83679a892e2d95755f2dac6acb0bfd1e9ac5d548 # v6.1.0
with:
python-version: '3.13'
- uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8 # v6.0.1
with:
fetch-depth: 0
fetch-tags: true

- name: Determine release info
id: release_info
Expand Down Expand Up @@ -78,16 +75,14 @@ jobs:
echo "No release found for $TAG."
fi

# Note that since this is a draft the link will be untagged (see https://github.com/cli/cli/issues/11589)
- name: Create draft release
- name: Create release
if: ${{ steps.release_info.outputs.tag }}
run: |
gh release create "${{ steps.release_info.outputs.tag }}" \
--repo "$GITHUB_REPOSITORY" \
--title "${{ steps.release_info.outputs.tag }}" \
--notes-file release_notes.txt \
--draft \
--verify-tag \
LICENSE
uses: softprops/action-gh-release@5122b4edc95f85501a71628a57dc180a03ec7588 # v2.5.0
with:
tag_name: ${{ steps.release_info.outputs.tag }}
name: ${{ steps.release_info.outputs.tag }}
body_path: release_notes.txt
draft: true
files: LICENSE
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
Loading