-
Notifications
You must be signed in to change notification settings - Fork 5
Update actions-gh-pages version in workflow #938
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Updated the version of peaceiris/actions-gh-pages used for publishing main cannot be used as stated in https://github.com/peaceiris/actions-gh-pages#%EF%B8%8F-release-strategy and peaceiris/actions-gh-pages#1107
|
Warning Rate limit exceeded@ben-edna has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 16 minutes and 31 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (1)
WalkthroughRemoved the branch-only condition from the docs landing-page Publish step and updated the peaceiris/pages action reference; also enabled Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested labels
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In @.github/workflows/docs.yml:
- Around line 58-60: Restore the branch-guard on the "Publish" workflow step so
it only runs for main by reintroducing the condition that checks the ref (e.g.,
the previous if: github.ref == 'refs/heads/main') on the Publish step that uses
peaceiris/actions-gh-pages, and optionally add an additional repository guard
(e.g., check github.repository equals the canonical dfetch-org repo) to prevent
forks or non-production contexts from publishing.
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/workflows/docs.yml
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-12-25T23:53:05.742Z
Learnt from: spoorcc
Repo: dfetch-org/dfetch PR: 861
File: .github/workflows/build.yml:120-125
Timestamp: 2025-12-25T23:53:05.742Z
Learning: When building macOS PKG installers with fpm in CI, account for the known issue (fpm #1996) where --prefix can be duplicated (e.g., /opt/dfetch becomes /opt/dfetch/opt/dfetch). In the workflow at .github/workflows/build.yml, verify install paths and PATH entries do not assume a single-prefix layout. Adjust packaging scripts or fpm arguments to normalize the final install location and update PATH references accordingly. Add a test step to validate the expected runtime paths after installation.
Applied to files:
.github/workflows/docs.yml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (14)
- GitHub Check: build / build (windows-latest)
- GitHub Check: build / build (macos-latest)
- GitHub Check: build / build (ubuntu-latest)
- GitHub Check: Codacy Static Code Analysis
- GitHub Check: run / run (windows-latest, 3.14)
- GitHub Check: run / run (ubuntu-latest, 3.13)
- GitHub Check: run / run (macos-latest, 3.10)
- GitHub Check: run / run (ubuntu-latest, 3.11)
- GitHub Check: run / run (macos-latest, 3.11)
- GitHub Check: run / run (windows-latest, 3.13)
- GitHub Check: run / run (ubuntu-latest, 3.14)
- GitHub Check: DevContainer Build & Test
- GitHub Check: docs / Landing page
- GitHub Check: run / test-cygwin
🔇 Additional comments (1)
.github/workflows/docs.yml (1)
60-60: Pinning topeaceiris/actions-gh-pagesv4.0.0 commit is correct.v4.0.0 remains the latest release, and the commit SHA pinning approach with the version comment aligns with current GitHub Actions security best practices (Jan 2026). This is the recommended way to ensure immutability and supply-chain security.
6da6717 to
d42e8cd
Compare
Updated the version of peaceiris/actions-gh-pages used for publishing main cannot be used as stated in https://github.com/peaceiris/actions-gh-pages#%EF%B8%8F-release-strategy and
peaceiris/actions-gh-pages#1107
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.