Skip to content

test: remove flaky basic_expiry integration test #695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lwshang wants to merge 4 commits into
base: main
Choose a base branch
from
Open

test: remove flaky basic_expiry integration test #695

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3473511
test: remove flaky basic_expiry integration test
lwshang Jan 28, 2026
b046456
test: fix flaky test_route_with_one_healthy_and_one_unhealthy_seed
lwshang Jan 30, 2026
5b447eb
test: improve wait_for_routing_to_domains reliability
lwshang Jan 30, 2026
0ab4ff3
Revert "test: improve wait_for_routing_to_domains reliability"
lwshang Jan 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 0 additions & 42 deletions ref-tests/tests/integration.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,48 +29,6 @@ use std::{
time::{Duration, SystemTime, UNIX_EPOCH},
};

#[tokio::test]
async fn basic_expiry() {
with_universal_canister(async move |_, agent, canister_id| {
let arg = payload().reply_data(b"hello").build();

// Verify this works first.
let result = agent
.update(&canister_id, "update")
.with_arg(arg.clone())
.expire_after(std::time::Duration::from_secs(120))
.call_and_wait()
.await?;

assert_eq!(result.as_slice(), b"hello");

// Verify a zero expiry will fail with the proper code.
let result = agent
.update(&canister_id, "update")
.with_arg(arg.clone())
.expire_after(std::time::Duration::from_secs(0))
.call_and_wait()
.await;

match result.unwrap_err() {
AgentError::TimeoutWaitingForResponse() => (),
x => panic!("Was expecting an error, got {:?}", x),
}

let result = agent
.update(&canister_id, "update")
.with_arg(arg.clone())
.expire_after(std::time::Duration::from_secs(120))
.call_and_wait()
.await?;

assert_eq!(result.as_slice(), b"hello");

Ok(())
})
.await
}

#[tokio::test]
async fn wait_signed() {
with_universal_canister(async move |_, mut agent, canister_id| {
Expand Down