-
Notifications
You must be signed in to change notification settings - Fork 104
feat: get_chunks_info query method #207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
e42d09f
added get_chunks_info query
3cL1p5e7 f30ca49
fix total_length type
3cL1p5e7 cc525f5
fixes by review: total_length as u64 and ChunkInfo.total_length -> ch…
3cL1p5e7 b2382b8
Merge branch 'main' into feature/get_chunks_info
lwshang 9f4c218
certified_assets: fix lint and fmt warnings
3cL1p5e7 ee736e3
Merge branch 'main' into feature/get_chunks_info
lwshang 99c28f2
ic-certified-assets: fix get_chunk_info encodings argument
3cL1p5e7 dfeb1cc
Merge branch 'main' into feature/get_chunks_info
lwshang File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We want to have certification of these results and to add certification for the get_chunk call. I don't know if we need to do that in this PR though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jplevyak
yes, most likely it is better to make a separate PR.
I am currently working on my own certified-assets-based chunk certification solution. If I succeed, then I will definitely share them in the PR format in order to at least discuss the solution
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jplevyak done :)
#219