Skip to content

fix: trap with 'Call already trapped' when using futures::stream #450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

fix: trap with 'Call already trapped' when using futures::stream #450

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/ic-cdk/src/api/call.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,6 +153,8 @@ unsafe extern "C" fn callback<T: AsRef<[u8]>>(state_ptr: *const RwLock<CallFutur
// borrow_mut() the state as well. So we need to be careful to not double-borrow_mut.
waker.wake()
}
} else {
crate::trap("Call already trapped");
Copy link
Contributor Author

@mraszyk mraszyk Dec 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
crate::trap("Call already trapped");
crate::trap("This call has not been awaited, e.g., because a previous callback trapped");

This could be more precise given an offline discussion with @adamspofford-dfinity

}
}

Expand Down