Add derived algorithm_version to node-rewards command#1875
Merged
pietrodimarco-dfinity merged 5 commits intomainfrom Jan 27, 2026
Merged
Add derived algorithm_version to node-rewards command#1875pietrodimarco-dfinity merged 5 commits intomainfrom
pietrodimarco-dfinity merged 5 commits intomainfrom
Conversation
severin-amrein
approved these changes
Jan 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for propagating
algorithm_versionwhen runningnode-rewards past-rewards <YYYY-MM>and when fetching daily rewards from NRC.The algorithm_version is derived directly from the governance rewards for the corresponding month and is required to correctly backtrack reward calculations now that NRC supports multiple algorithm versions.
Note
Adds support for selecting the NRC rewards calculation algorithm.
NodeRewardsCtxwith optionalalgorithm_versionand passes it to NRC viaget_rewards_daily(day, algorithm_version)past-rewardsderivesalgorithm_versionfrom governance snapshot and uses it for all daily fetches;ongoingsets it toNoneNodeRewardsCanisterWrapper) request payload to include optionalalgorithm_versionic-error-typessource referencesWritten by Cursor Bugbot for commit 98516b3. This will update automatically on new commits. Configure here.