Skip to content

Add base and adjusted rewards total to summary csv#1876

Merged
pietrodimarco-dfinity merged 2 commits intomainfrom
pmarco/add-columns-csv-generated
Jan 28, 2026
Merged

Add base and adjusted rewards total to summary csv#1876
pietrodimarco-dfinity merged 2 commits intomainfrom
pmarco/add-columns-csv-generated

Conversation

@pietrodimarco-dfinity
Copy link
Contributor

@pietrodimarco-dfinity pietrodimarco-dfinity commented Jan 28, 2026

This pull request enhances the node provider summary CSV output in the node rewards CLI by including additional reward metrics and updating the function interface to support this new data.

CSV Output Enhancements:

  • The create_node_providers_summary_csv function now includes two new columns in the CSV output: total_base_rewards_xdr_permyriad and total_adjusted_rewards_xdr_permyriad, which represent the summed base and adjusted rewards for each provider across all days. [1] [2]

Note

Adds aggregated reward totals to the node provider summary CSV and removes the provider filter option.

  • Extends create_node_providers_summary_csv to accept nrc_data and outputs new columns: total_base_rewards_xdr_permyriad and total_adjusted_rewards_xdr_permyriad (summed across all days). Updates call site in generate_csv_files_by_provider to pass nrc_data.
  • Removes provider filtering: deletes provider_id from CommonArgs and NodeRewardsCtx, removes filtering logic in fetch_nrc_data, and updates ongoing/past_rewards to no longer set it.

Written by Cursor Bugbot for commit 18a4474. This will update automatically on new commits. Configure here.

@pietrodimarco-dfinity pietrodimarco-dfinity requested a review from a team as a code owner January 28, 2026 09:50
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 2 potential issues.

Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.

This is the final PR Bugbot will review for you during this billing cycle

Your free Bugbot reviews will reset on February 1

Details

Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.

To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.

@pietrodimarco-dfinity pietrodimarco-dfinity enabled auto-merge (squash) January 28, 2026 10:24
@pietrodimarco-dfinity pietrodimarco-dfinity merged commit 39df9c9 into main Jan 28, 2026
9 checks passed
@pietrodimarco-dfinity pietrodimarco-dfinity deleted the pmarco/add-columns-csv-generated branch January 28, 2026 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants