Add base and adjusted rewards total to summary csv#1876
Merged
pietrodimarco-dfinity merged 2 commits intomainfrom Jan 28, 2026
Merged
Add base and adjusted rewards total to summary csv#1876pietrodimarco-dfinity merged 2 commits intomainfrom
pietrodimarco-dfinity merged 2 commits intomainfrom
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
This is the final PR Bugbot will review for you during this billing cycle
Your free Bugbot reviews will reset on February 1
Details
Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
severin-amrein
approved these changes
Jan 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request enhances the node provider summary CSV output in the node rewards CLI by including additional reward metrics and updating the function interface to support this new data.
CSV Output Enhancements:
create_node_providers_summary_csvfunction now includes two new columns in the CSV output:total_base_rewards_xdr_permyriadandtotal_adjusted_rewards_xdr_permyriad, which represent the summed base and adjusted rewards for each provider across all days. [1] [2]Note
Adds aggregated reward totals to the node provider summary CSV and removes the provider filter option.
create_node_providers_summary_csvto acceptnrc_dataand outputs new columns:total_base_rewards_xdr_permyriadandtotal_adjusted_rewards_xdr_permyriad(summed across all days). Updates call site ingenerate_csv_files_by_providerto passnrc_data.provider_idfromCommonArgsandNodeRewardsCtx, removes filtering logic infetch_nrc_data, and updatesongoing/past_rewardsto no longer set it.Written by Cursor Bugbot for commit 18a4474. This will update automatically on new commits. Configure here.