Skip to content

chore: updating refs#1914

Merged
NikolaMilosa merged 4 commits intomainfrom
nim-updating-refs
Mar 11, 2026
Merged

chore: updating refs#1914
NikolaMilosa merged 4 commits intomainfrom
nim-updating-refs

Conversation

@NikolaMilosa
Copy link
Copy Markdown
Contributor

@NikolaMilosa NikolaMilosa commented Mar 2, 2026

Note

Medium Risk
While the changes are mostly pinned-ref updates, they affect core dependency resolution and the exact ic-admin/registry interfaces used at runtime, so mismatches can break builds or operational tooling.

Overview
Bumps the pinned dfinity/ic git revision across the workspace (Rust Cargo.toml git deps, Bazel MODULE.bazel IC_REPO_VERSION, ic-revisions.json, and the build Docker image’s ic-admin download), keeping all build systems aligned on the same upstream commit.

Adjusts IC tooling integration to be more robust at runtime: pylib/ic_admin.py can resolve the ic-admin version from the NNS canister metadata when not explicitly provided, and multiservice-discovery DTO parsing adds stricter validation (NNS reachability checks and public key/job-type validation) before accepting new definitions.

Written by Cursor Bugbot for commit a6bdfd2. This will update automatically on new commits. Configure here.

@NikolaMilosa NikolaMilosa requested a review from a team as a code owner March 2, 2026 14:33
Copy link
Copy Markdown

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Free Tier Details

Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.

To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.

Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

@github-actions
Copy link
Copy Markdown
Contributor

MSD Diff

No diff

@NikolaMilosa NikolaMilosa merged commit d1c8574 into main Mar 11, 2026
11 checks passed
@NikolaMilosa NikolaMilosa deleted the nim-updating-refs branch March 11, 2026 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants