feat: Improve QR scanning reliability for dark borderless codes#757
Closed
AntonioVentilii wants to merge 3 commits intomainfrom
Closed
feat: Improve QR scanning reliability for dark borderless codes#757AntonioVentilii wants to merge 3 commits intomainfrom
AntonioVentilii wants to merge 3 commits intomainfrom
Conversation
AntonioVentilii
had a problem deploying
to
release
GitHub Actions
Failure
Collaborator
Author
|
We tried it and it didn't work. It really seems to be a limitation of the library we are using (more details in the description): the issue are inverted colors (light fill on dark background). This is fundamentally broken in |
AntonioVentilii
deleted the
feat/Improve-QR-scanning-reliability-for-dark-borderless-codes
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Dark QR codes without a proper quiet zone were difficult to detect due to the constrained scan area (
qrbox).We increase the scan region to improve detection tolerance, especially for low-contrast and borderless codes.
Changes
Tests
Tested manually with OISY: we weren't able to scan a dark, borderless QR code with mobile; now we must be able to do it --> ❗️❗️❗️FAILURE❗️❗️❗️
Note
This is a known issue of library
html5-qrcode(that is now in maintenance mode):