chore: separate cors layer for HTTP gateway#65
Merged
Conversation
Contributor
Author
|
They are not tested here and I don't think it makes sense to test them. It makes sense to test the CORS headers on the API calls, but not on the HTTP gateway requests as there we anyway want to go for "developer-defined" ones. I would merge it as is and then think about testing once we overhaul that part. |
nikolay-komarevskiy
approved these changes
Feb 24, 2025
github-merge-queue bot
pushed a commit
to dfinity/ic
that referenced
this pull request
Feb 27, 2025
…cketIC HTTP gateway (#4154) This PR reflects ic-gateway [PR](dfinity/ic-gateway#65) in the PocketIC HTTP gateway implementation.
github-merge-queue bot
pushed a commit
to dfinity/ic
that referenced
this pull request
Feb 28, 2025
…cketIC HTTP gateway (#4154) This PR reflects ic-gateway [PR](dfinity/ic-gateway#65) in the PocketIC HTTP gateway implementation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.