Skip to content

Commit 80fde00

Browse files
Merge branch 'alin/MR-427-drop-after_split-assert' into 'master'
fix: [MR-427] Drop redundant assert in `after_split()` `ReplicatedState::consensus_queue` is empty at all round boundaries. So we can safely assert this fact in `ReplicatedState::split()`. But `ReplicatedState::after_split()` runs on top of the mutable tip; and while it is called as early as possible, before anything is pushed onto `consensus_queue`, making the same assertion again is either redundant (if nothing changed) or dangerous (if anything was enqueued at the beginning of the round). See merge request dfinity-lab/public/ic!12675
2 parents 2ff6c12 + 64c3aa9 commit 80fde00

File tree

1 file changed

+0
-3
lines changed

1 file changed

+0
-3
lines changed

rs/replicated_state/src/replicated_state.rs

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -926,9 +926,6 @@ impl ReplicatedState {
926926
.split_from
927927
.expect("Not a state resulting from a subnet split");
928928

929-
// Consensus queue is always empty at the end of the round.
930-
assert!(consensus_queue.is_empty());
931-
932929
// Adjust `CanisterQueues::(local|remote)_subnet_input_schedule` based on which
933930
// canisters are present in `canister_states`.
934931
let local_canister_ids = canister_states.keys().cloned().collect::<Vec<_>>();

0 commit comments

Comments
 (0)