You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Merge branch 'alin/MR-427-drop-after_split-assert' into 'master'
fix: [MR-427] Drop redundant assert in `after_split()`
`ReplicatedState::consensus_queue` is empty at all round boundaries. So we
can safely assert this fact in `ReplicatedState::split()`.
But `ReplicatedState::after_split()` runs on top of the mutable tip; and while
it is called as early as possible, before anything is pushed onto
`consensus_queue`, making the same assertion again is either redundant (if
nothing changed) or dangerous (if anything was enqueued at the beginning of the
round).
See merge request dfinity-lab/public/ic!12675
0 commit comments